From owner-freebsd-current@freebsd.org Mon Jun 20 14:18:04 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 98ACAA78A49 for ; Mon, 20 Jun 2016 14:18:04 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 76E0814B1 for ; Mon, 20 Jun 2016 14:18:04 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id 6F25FA78A46; Mon, 20 Jun 2016 14:18:04 +0000 (UTC) Delivered-To: current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6E7BBA78A44; Mon, 20 Jun 2016 14:18:04 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-io0-x22c.google.com (mail-io0-x22c.google.com [IPv6:2607:f8b0:4001:c06::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 36E3814AF; Mon, 20 Jun 2016 14:18:04 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-io0-x22c.google.com with SMTP id f30so122924442ioj.2; Mon, 20 Jun 2016 07:18:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=aSTFxSQHnqXqp0ZxEqAO17TAb9PpagTVJzuXiV0xEbw=; b=HIezpgehjete5ldt32UpVFBjCTzAgoRLWELIb3UD8KY7GHjgtQxb4SVDDe0Mb34uSR YphWiQ2OQ3O3EGOlojwP9Kfu/XGrAAuJLwvjoZKB73leOh+v5/WWpcCutyHguj355DRb IpdrjC+L55QiWwG2i40fXvwKd/KcNw81gHhRXz2OIhm3iCe23NqQud9m6PuzfBuS0VC4 Zht6czzsXZzOe4C4TWGMnNC5wvagq1ps2uUxt3iJoHtqctumc1siZurb6ro3f5m81KeU uYd09prH7xNZRabe0ZZu31Jl80IHfR7xnax+1pcfqoJDyHVU5Ks/xBPTWZ8KQ+uqSxHL wmmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=aSTFxSQHnqXqp0ZxEqAO17TAb9PpagTVJzuXiV0xEbw=; b=e5hMQYebCDIjvIsTQGvrfT4LhBtK8yKT9iEolyq6CfVpyOs5cv/3j38uQJmnddcJ0g Vx7uicFKf16C+DJJES21lIh27XYNypdfLCScd7oaW2IJC6XzWR9ry2gPk6ScjBrEZBU0 NUuZCXosXiu8AgzXAkGFX4/FbQJjroqLehJMAHegvCZgmmW0OYET/II7GO7cmT1IBRVU fovKK6ZZsVjcVUksVN4VWq1JhaWRy3HTEfHWlvN8O9YkyLDpPwiK+dJmYOdDMHvOC+ho b5AIQs7Olk/JG+yvp/qVHAYko0GG04Z86k+rJN1QbHnE/3FDp3RjZUUTn/vQ0nSbpQqy Yh3g== X-Gm-Message-State: ALyK8tLjRSirQE9Z5+jC4A+S6tXF0ez2+/tB68AHtNZV034W/p3Zvn97ZcNNQ35Tv530f/7E3biRgX1+X2zWDg== X-Received: by 10.107.37.19 with SMTP id l19mr23129896iol.75.1466432282575; Mon, 20 Jun 2016 07:18:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.210.212 with HTTP; Mon, 20 Jun 2016 07:18:01 -0700 (PDT) In-Reply-To: References: <20160617045319.GE1076@FreeBSD.org> <1f28844b-b4ea-b544-3892-811f2be327b9@freebsd.org> <20160620073917.GI1076@FreeBSD.org> <1d18d0e2-3e42-cb26-928c-2989d0751884@freebsd.org> <20160620095822.GJ1076@FreeBSD.org> <20160620103015.GK1076@FreeBSD.org> From: Adrian Chadd Date: Mon, 20 Jun 2016 07:18:01 -0700 Message-ID: Subject: Re: panic with tcp timers To: Hans Petter Selasky Cc: Gleb Smirnoff , Julien Charbon , "net@freebsd.org" , "current@freebsd.org" , Randall Stewart Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jun 2016 14:18:04 -0000 There's implications for RSS with how the callout system currently works. If you don't know the RSS bucket ID of a connection in advance, you'll create callouts on the wrong CPUs and then they're not migrated. The initial work here did convert things over, but didn't place the callouts in the right CPU/RSS bucket and there wasn't a mechanism to fix this. :( (But I'm also a firm believer of that too. I'd also finally just like the callout system to not be tied to per-CPU queues, but also per-RSS-bucket callout wheels so we could assign a CPU mask to a given callout wheel and then migrating things around is just "change cpu mask", not "change callout cpu id.") -adrian On 20 June 2016 at 04:00, Hans Petter Selasky wrote: > On 06/20/16 12:30, Gleb Smirnoff wrote: >> >> What does prevent us from converting TCP timeouts to locked? To my >> understanding it is the lock order of taking pcbinfo after pcb lock. > > > I started this work: > > https://reviews.freebsd.org/D1563 > > --HPS > _______________________________________________ > freebsd-net@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"