Date: Mon, 20 Jun 2016 07:18:01 -0700 From: Adrian Chadd <adrian.chadd@gmail.com> To: Hans Petter Selasky <hps@selasky.org> Cc: Gleb Smirnoff <glebius@freebsd.org>, Julien Charbon <jch@freebsd.org>, "net@freebsd.org" <net@freebsd.org>, "current@freebsd.org" <current@freebsd.org>, Randall Stewart <rrs@freebsd.org> Subject: Re: panic with tcp timers Message-ID: <CAJ-VmokA49M6SAWLp83gawg2e67vy90SoLjdgEey_Vy6NFp0Bg@mail.gmail.com> In-Reply-To: <edf5075e-7bad-e30c-0674-22de1815aadd@selasky.org> References: <20160617045319.GE1076@FreeBSD.org> <1f28844b-b4ea-b544-3892-811f2be327b9@freebsd.org> <20160620073917.GI1076@FreeBSD.org> <1d18d0e2-3e42-cb26-928c-2989d0751884@freebsd.org> <20160620095822.GJ1076@FreeBSD.org> <b81aa248-4b97-3162-7636-da655163cdcc@selasky.org> <20160620103015.GK1076@FreeBSD.org> <edf5075e-7bad-e30c-0674-22de1815aadd@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
There's implications for RSS with how the callout system currently works. If you don't know the RSS bucket ID of a connection in advance, you'll create callouts on the wrong CPUs and then they're not migrated. The initial work here did convert things over, but didn't place the callouts in the right CPU/RSS bucket and there wasn't a mechanism to fix this. :( (But I'm also a firm believer of that too. I'd also finally just like the callout system to not be tied to per-CPU queues, but also per-RSS-bucket callout wheels so we could assign a CPU mask to a given callout wheel and then migrating things around is just "change cpu mask", not "change callout cpu id.") -adrian On 20 June 2016 at 04:00, Hans Petter Selasky <hps@selasky.org> wrote: > On 06/20/16 12:30, Gleb Smirnoff wrote: >> >> What does prevent us from converting TCP timeouts to locked? To my >> understanding it is the lock order of taking pcbinfo after pcb lock. > > > I started this work: > > https://reviews.freebsd.org/D1563 > > --HPS > _______________________________________________ > freebsd-net@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-VmokA49M6SAWLp83gawg2e67vy90SoLjdgEey_Vy6NFp0Bg>