From owner-freebsd-hackers@FreeBSD.ORG  Sat Aug 21 09:00:06 2004
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1849C16A4D2
	for <hackers@freebsd.org>; Sat, 21 Aug 2004 09:00:06 +0000 (GMT)
Received: from out008.verizon.net (out008pub.verizon.net [206.46.170.108])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8E39E43D62
	for <hackers@freebsd.org>; Sat, 21 Aug 2004 09:00:03 +0000 (GMT)
	(envelope-from skip.ford@verizon.net)
Received: from pool-70-17-33-167.pskn.east.verizon.net ([70.17.33.167])
	by out008.verizon.netESMTP
	<20040821090002.QAPL8960.out008.verizon.net@pool-70-17-33-167.pskn.east.verizon.net>;
	Sat, 21 Aug 2004 04:00:02 -0500
Date: Sat, 21 Aug 2004 05:00:01 -0400
From: Skip Ford <skip.ford@verizon.net>
To: Maxim Konovalov <maxim@macomnet.ru>
Message-ID: <20040821090001.GB593@lucy.pool-70-17-33-167.pskn.east.verizon.net>
References: <412652AA.5020308@coverity.com>
	<20040821120624.I34489@mp2.macomnet.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040821120624.I34489@mp2.macomnet.net>
User-Agent: Mutt/1.4.2.1i
X-Authentication-Info: Submitted using SMTP AUTH at out008.verizon.net from
	[70.17.33.167] at Sat, 21 Aug 2004 04:00:02 -0500
cc: hackers@freebsd.org
cc: Ted Unangst <tedu@coverity.com>
Subject: Re: off by one bounds
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 21 Aug 2004 09:00:06 -0000

Maxim Konovalov wrote:
> On Fri, 20 Aug 2004, 12:36-0700, Ted Unangst wrote:
> 
>> errors in freebsd 4.10 found by Coverity's analysis.
> 
>> ip_icmp.c:ip_next_mtu, i == sizeof, dir >= 0
> 
> If i == sizeof then mtutab[i] == 0

If "i == sizeof" then mtutab[i] is out of bounds, off by one.
There is no mtutab[sizeof mtutab / sizeof mtutab[0]].

This isn't specific to RELENG_4.

-- 
Skip