From owner-p4-projects@FreeBSD.ORG Tue Sep 22 13:15:52 2009 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id D66B41065697; Tue, 22 Sep 2009 13:15:51 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9A3091065679 for ; Tue, 22 Sep 2009 13:15:51 +0000 (UTC) (envelope-from stas@freebsd.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 89CFA8FC33 for ; Tue, 22 Sep 2009 13:15:51 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n8MDFp9e048949 for ; Tue, 22 Sep 2009 13:15:51 GMT (envelope-from stas@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n8MDFpCt048947 for perforce@freebsd.org; Tue, 22 Sep 2009 13:15:51 GMT (envelope-from stas@freebsd.org) Date: Tue, 22 Sep 2009 13:15:51 GMT Message-Id: <200909221315.n8MDFpCt048947@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to stas@freebsd.org using -f From: Stanislav Sedov To: Perforce Change Reviews Cc: Subject: PERFORCE change 168772 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Sep 2009 13:15:52 -0000 http://perforce.freebsd.org/chv.cgi?CH=168772 Change 168772 by stas@stas_yandex on 2009/09/22 13:15:47 - Do not try to read stabs on amd64, it doesn't work well. The reader is broken on amd64-linux as well. Affected files ... .. //depot/projects/valgrind/coregrind/m_debuginfo/readelf.c#10 edit Differences ... ==== //depot/projects/valgrind/coregrind/m_debuginfo/readelf.c#10 (text+ko) ==== @@ -2007,9 +2007,9 @@ } /* Read the stabs and/or dwarf2 debug information, if any. It - appears reading stabs stuff on amd64-linux doesn't work, so - we ignore it. */ -# if !defined(VGP_amd64_linux) + appears reading stabs stuff on amd64-linux and amd64-freebsd + doesn't work, so we ignore it. */ +# if !defined(VGP_amd64_linux) && !defined(VGP_amd64_freebsd) if (stab_img && stabstr_img) { ML_(read_debuginfo_stabs) ( di, stab_img, stab_sz, stabstr_img, stabstr_sz );