Date: Fri, 3 Mar 2006 21:15:07 GMT From: Andrew Webster <awebster@connectalk.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/94054: pkg_fetch doesn't uses wrong directory (All or Latest) Message-ID: <200603032115.k23LF7Gw099897@www.freebsd.org> Resent-Message-ID: <200603032120.k23LK4hG060622@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 94054 >Category: ports >Synopsis: pkg_fetch doesn't uses wrong directory (All or Latest) >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Mar 03 21:20:03 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Andrew Webster >Release: 5.4-p12 >Organization: ConnecTalk Inc. >Environment: FreeBSD buildbox.connectalk.com 5.4-RELEASE-p12 FreeBSD 5.4-RELEASE-p12 #1: Wed Mar 1 18:59:19 EST 2006 root@buildbox.connectalk.com:/usr/obj/usr/src/sys/GENERIC i386 >Description: I'm no ruby expert, but the logic looks dubious to me. The decision to choose the latest is based on whether or not there is a dash (-) in the filename. (Line 169 of pkg_fetch). As a result, postgresql74-server sets latest to false. postgresql74 sets latest to true, however there is no such thing as postgresql74 in packages, it is either -client or -server, etc. I think the author was intending to use the - to indicate the beginning of a version number, but that logic is somewhat flawed given the package naming conventions. >How-To-Repeat: pkg_fetch -v databases/postgresql74-server >Fix: Need to change logic to decided when to use All or Latest directory of packages directory on remote site. >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200603032115.k23LF7Gw099897>