From owner-cvs-all@FreeBSD.ORG Mon May 7 20:53:25 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B1F2716A406; Mon, 7 May 2007 20:53:25 +0000 (UTC) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (gate.funkthat.com [69.17.45.168]) by mx1.freebsd.org (Postfix) with ESMTP id 7699513C447; Mon, 7 May 2007 20:53:25 +0000 (UTC) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (p005gmuujaae58w0@localhost.funkthat.com [127.0.0.1]) by hydrogen.funkthat.com (8.13.6/8.13.3) with ESMTP id l47KrOQk034662; Mon, 7 May 2007 13:53:24 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.13.6/8.13.3/Submit) id l47KrOHV034661; Mon, 7 May 2007 13:53:24 -0700 (PDT) (envelope-from jmg) Date: Mon, 7 May 2007 13:53:24 -0700 From: John-Mark Gurney To: John Baldwin Message-ID: <20070507205323.GT17958@funkthat.com> References: <200705061702.l46H2oVK057260@repoman.freebsd.org> <20070506174426.GO17958@funkthat.com> <20070506191027.GA2050@tin.it> <200705071354.00455.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200705071354.00455.jhb@freebsd.org> User-Agent: Mutt/1.4.2.1i X-Operating-System: FreeBSD 5.4-RELEASE-p6 i386 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, Paolo Pisati Subject: Re: cvs commit: src/sys/amd64/amd64 intr_machdep.c src/sys/i386/i386 intr_machdep.c src/sys/kern kern_intr.c src/sys/sys interrupt.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: John-Mark Gurney List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 May 2007 20:53:25 -0000 John Baldwin wrote this message on Mon, May 07, 2007 at 13:53 -0400: > On Sunday 06 May 2007 03:10:27 pm Paolo Pisati wrote: > > On Sun, May 06, 2007 at 10:44:26AM -0700, John-Mark Gurney wrote: > > > Paolo Pisati wrote this message on Sun, May 06, 2007 at 17:02 +0000: > > > > Modified files: > > > > sys/amd64/amd64 intr_machdep.c > > > > sys/i386/i386 intr_machdep.c > > > > sys/kern kern_intr.c > > > > sys/sys interrupt.h > > > > Log: > > > > Bring in the reminaing bits to make interrupt filtering work: > > > > > > When are we going to see man page updates to document this new feature? > > > > didn't prepare any patch for man pages cause the support for some > > archs is still missing, but i can do that if requested. > > > > > Also, you forgot to update sys/sys/bus.h's comments? or did you fix > > > the code to behave like the comments? > > > > you mean this comment: > > > > --------8<--------8<--------8<--------8<--------8<--------8<-------- > > > > /** > > * @brief Driver interrupt filter return values > > * > > * If a driver provides an interrupt filter routine it must return an > > * integer consisting of oring together zero or more of the following > > * flags: > > * > > * FILTER_STRAY - this device did not trigger the interrupt > > * FILTER_HANDLED - the interrupt has been fully handled and can be > EOId > > * FILTER_SCHEDULE_THREAD - the threaded interrupt handler should be > > * scheduled to execute > > * > > * If the driver does not provide a filter, then the interrupt code will > > * act is if the filter had returned FILTER_SCHEDULE_THREAD. Note that it > > * is illegal to specify any other flag with FILTER_STRAY and that it is > > * illegal to not specify either of FILTER_HANDLED or FILTER_SCHEDULE_THREAD > > * if FILTER_STRAY is not specified. > > */ > > #define FILTER_STRAY 0x01 > > #define FILTER_HANDLED 0x02 > > #define FILTER_SCHEDULE_THREAD 0x04 > > My suggestion on this a while back btw was to convert this from a bitmask to > an "enum" and have FILTER_SCHEDULE_THREAD be 3 and imply FILTER_HANDLED, and > filters return 1 of the 3 values. That's fine w/ me.. as long as it's documented as such... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."