From owner-freebsd-net@FreeBSD.ORG  Sun Mar 23 15:26:00 2014
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id AFE37173;
 Sun, 23 Mar 2014 15:26:00 +0000 (UTC)
Received: from mail-qc0-x230.google.com (mail-qc0-x230.google.com
 [IPv6:2607:f8b0:400d:c01::230])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 5E01E5E7;
 Sun, 23 Mar 2014 15:26:00 +0000 (UTC)
Received: by mail-qc0-f176.google.com with SMTP id m20so4846080qcx.21
 for <multiple recipients>; Sun, 23 Mar 2014 08:25:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=cyuQauoe/J6AkMxKPLTbY4Njijeo4IEvd/3XQyhlgwg=;
 b=ZZPXJ1jzlNmMIazADJ0oyf24VoA7vw6N95gY+yM9WDxKwZYq3hns1KWX7VwW6FTceu
 brKvUhVCYn7qCyXzrsNO3bWZxjyxsPZCPawkX6R32jollJhDyE5szfuAWUHsVtR+s4wU
 0N5OxZe/elvAc9TyEC54iWJimPQbcFyhhN++/VxSOgW2NkXuiIip7eB9JZkfZRNuvU8Y
 l7sV1Zd2zNg5AtFyu1gj/bQ2TBT3NoZzq7gcQECSK3t1VkVRuAoLGgdCNdKXuaErrlG2
 OPLAaNkswU2SSYLP5YXKwiNsSOfM5xKg8MKOpQpUOruYA5RUrWO7QqP8wCg1V+t5lDaQ
 BDTw==
MIME-Version: 1.0
X-Received: by 10.140.80.209 with SMTP id c75mr2319514qgd.79.1395588359602;
 Sun, 23 Mar 2014 08:25:59 -0700 (PDT)
Received: by 10.96.79.97 with HTTP; Sun, 23 Mar 2014 08:25:59 -0700 (PDT)
In-Reply-To: <1532337187.1452820.1395543491196.JavaMail.root@uoguelph.ca>
References: <CAB2_NwADUfs+bKV9QE_C4B1vchnzGWr1TK4C7wP8Fh8m94_mHA@mail.gmail.com>
 <1532337187.1452820.1395543491196.JavaMail.root@uoguelph.ca>
Date: Sun, 23 Mar 2014 12:25:59 -0300
Message-ID: <CAB2_NwBBvhQOkNFwj9RdwHTB5DT5OTmczR8UgsciS0UP2LkrdQ@mail.gmail.com>
Subject: Re: 9.2 ixgbe tx queue hang
From: Christopher Forgeron <csforgeron@gmail.com>
To: Rick Macklem <rmacklem@uoguelph.ca>
Content-Type: text/plain; charset=ISO-8859-1
X-Content-Filtered-By: Mailman/MimeDel 2.1.17
Cc: FreeBSD Net <freebsd-net@freebsd.org>,
 Garrett Wollman <wollman@freebsd.org>, Jack Vogel <jfvogel@gmail.com>,
 Markus Gebert <markus.gebert@hostpoint.ch>
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 23 Mar 2014 15:26:00 -0000

On Sat, Mar 22, 2014 at 11:58 PM, Rick Macklem <rmacklem@uoguelph.ca> wrote:

> Christopher Forgeron wrote:
> >
>
> > Also should we not also subtract ETHER_VLAN_ENCAP_LEN from tsomax to
> > make sure VLANs fit?
> >
> I took a look and, yes, this does seem to be needed. It will only be
> needed for the case where a vlan is in use and hwtagging is disabled,
> if I read the code correctly.
>

Yes, or in the rare care where you configure your switch to pass the v_lan
header through to the NIC.

>
> Do you use vlans?
>

(Answered in above email)


>
> I've attached an updated patch.
>
> It might be nice to have the printf() patch in the driver too, so
> we can see how big the ones that are too big are?
>
>
Yes, I'm going to leave those in until I know we have this fixed..  will
probably leave it in a while longer as it should only have a minor
performance impact to iter-loop like that, and I'd like to see what the
story is a few months down the road.

Thanks for the patches, will have to start giving them code-names so we can
keep them straight.  :-) I guess we have printf, tsomax, and this one.