Date: Sat, 23 Sep 2006 21:25:30 +0200 From: mlfbsd <mlfbsd@ci0.org> To: Gardner Bell <gbell72@rogers.com> Cc: freebsd-arm@freebsd.org Subject: Re: ks8695_reg.h Message-ID: <20060923192530.GA22568@ci0.org> In-Reply-To: <20060923191007.36367.qmail@web88012.mail.re2.yahoo.com> References: <20060923191007.36367.qmail@web88012.mail.re2.yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Gardner, On Sat, Sep 23, 2006 at 03:10:07PM -0400, Gardner Bell wrote: > Hello everyone, > > I'm presently working on the KS8695 registers header file and am > curious what I should and should not include in this file. At the > moment I have included almost every register that the data sheets > mention. Is this a good idea, or should I make separate header files > for things like the UART and memory controller registers? I've > included a copy of what I have done so far. Any help and or > recommendations you can offer, particularly on my naming conventions is > most welcome. > Great to hear ! I think defining all the registers is a good thing, as you can't always guess which one you would use. If when you'll define each individual bits it becomes to big, you may want to do a seperate file for the UART, but I think the others can stay here. Oh and I see nothing wrong with your naming convention :) Cheers, Olivier
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060923192530.GA22568>