From nobody Thu Apr 25 21:44:45 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VQTsq1Qgvz5JcYZ; Thu, 25 Apr 2024 21:45:03 +0000 (UTC) (envelope-from maciphone2@googlemail.com) Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VQTsp6lZHz427Z; Thu, 25 Apr 2024 21:45:02 +0000 (UTC) (envelope-from maciphone2@googlemail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-571e3f40e31so1326166a12.2; Thu, 25 Apr 2024 14:45:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20230601; t=1714081499; x=1714686299; darn=freebsd.org; h=message-id:in-reply-to:to:references:date:subject:mime-version:from :from:to:cc:subject:date:message-id:reply-to; bh=rklUYOXZOuzPvGh/mfeHzDD7eCpuvjcoWmeqVa8NC+w=; b=Eh1p+03q7iYBQQEIVccjMTELp86cpPdnh4P1b4CmdkTNRFEs9QYqY63hcFE380AjBL b6IQ5RVZZrUeWv0FKx1DGsYmoW9Y5cQe0rvkJgSAj+Pr14KEVa1FfrVs6irpZ/s5nTih inPF3rp2reLCJR5SsM9c+FftJvDuk0uBFXkOyVDY38HMI+VftqSXoEv+Uf/B7pVVBVCY oQpzmvTZH2gC3LQ38z9CgM1xQqxIMJcTgTHtHgx3QRzWGd2F66C3NVW+IbjDCmaheLtf JzoOpyzNPjJoenuIkKrzkY4Oh1V/jvZohZhffifVs/5Z0B0S+TIWmsm+nP5v5hjmI2pE bBNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714081499; x=1714686299; h=message-id:in-reply-to:to:references:date:subject:mime-version:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rklUYOXZOuzPvGh/mfeHzDD7eCpuvjcoWmeqVa8NC+w=; b=emeRrAH44Cm+4GlCsSQbwVdGmqbGQEvdz8f3ES0fWY2WnosswB+YbVaS1TxwfKW9K2 O4B+O26s4AJhurUbto24WySdhg5CH4duAKFgPAp5aQSkzrwxWXmUiJTW5cSj15334GsC 1Jgevu40TZmf1yQWuasVnYU4azQPoaJOX7R8ZPUqdVazRpsPmWRLFGIVQiQflkA4OJ9q Ioa9TK1MlcP7J+wE7YQMxk2IkOljeR/oPhqU4NQx/K9tAtggbHqDthdZ0NWSoSeO9pjL UM1HP8I4Houpcaa+z6OANgLRggFjMfvmCbYC7plexRbtXKBVoP2nCx4kRWAhYevKH1Cm Ft4A== X-Forwarded-Encrypted: i=1; AJvYcCUmOwOFo993/Pzi5LhkYKUs6GnmmefLq80dX5CtCd6ok3eem2XX7wHUnVKPLhB6nv3hpod4vemDrc+pBnioGhKhHCwdKHzCHlrcZH2rqHhz7UsyP56tfjVS3f5pvHCFDCPYv692OCRxMMog7/cD/tDCUeSPfRV1hwlCxA5cPqNSyLRwS51tSLc2ZfO5O6g= X-Gm-Message-State: AOJu0YxKc2oz5HI/pxnoi6sMJ7QV92MpW5Zzsr1thq4h3ZOCNziZG8JB gdCYyVyaMWl2HiCzQ/5AW9U6dEFAxSfzfbyhalFAGj0+yObSeumULMtRmQ== X-Google-Smtp-Source: AGHT+IEvaaNEXNdQYRBqOztU5dc1jCq96l+FGWeThWUHgw+A1qswKdxBH6FYtDp98qFWsOnLjqyg2Q== X-Received: by 2002:a50:9352:0:b0:56b:c210:870c with SMTP id n18-20020a509352000000b0056bc210870cmr528438eda.15.1714081498757; Thu, 25 Apr 2024 14:44:58 -0700 (PDT) Received: from smtpclient.apple (dynamic-046-115-021-017.46.115.pool.telefonica.de. [46.115.21.17]) by smtp.googlemail.com with ESMTPSA id u25-20020a056402111900b005720c59dc57sm4998961edv.23.2024.04.25.14.44.57 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Apr 2024 14:44:58 -0700 (PDT) From: =?utf-8?Q?Klaus_K=C3=BCchemann?= Content-Type: multipart/alternative; boundary="Apple-Mail=_022483E1-1624-4E13-9994-F726AF53F022" List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.500.171.1.1\)) Subject: Re: git: 1bd4f769caf8 - main - add dtb support for RPI CM4, CM4s, CM4_ioBoard Date: Thu, 25 Apr 2024 23:44:45 +0200 References: <202404192311.43JNBiVS059729@gitrepo.freebsd.org> <0100018f169ec80a-47d419c2-2cd6-4ee1-89da-3f4782429089-000000@email.amazonses.com> <0100018f16c8f23a-eacbe781-3f6e-4f02-9b4d-d26468364b1f-000000@email.amazonses.com> <7473b5ed-433b-4d51-8a23-cf6464eb4416@FreeBSD.org> To: Kyle Evans , cperciva@tarsnap.com, Warner Losh , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org In-Reply-To: <7473b5ed-433b-4d51-8a23-cf6464eb4416@FreeBSD.org> Message-Id: <7FA67865-F391-4773-86BA-9998B3EC855E@googlemail.com> X-Mailer: Apple Mail (2.3774.500.171.1.1) X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Queue-Id: 4VQTsp6lZHz427Z --Apple-Mail=_022483E1-1624-4E13-9994-F726AF53F022 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > Am 25.04.2024 um 22:01 schrieb Kyle Evans : >=20 > On 4/25/24 14:43, Colin Percival wrote: >> On 4/25/24 12:24, Warner Losh wrote: >>> On Thu, Apr 25, 2024, 12:57=E2=80=AFPM Colin Percival = > wrote: >>> On 4/19/24 16:11, Warner Losh wrote: >>> > add dtb support for RPI CM4, CM4s, CM4_ioBoard >>> > >>> > Signed-off-by: Klaus K=C3=BCchemann = >> > >>> > Reviewed by: imp >>> > Pull Request: = https://github.com/freebsd/freebsd-src/pull/1182 >>> >>> > --- >>> > --- a/release/arm64/RPI.conf >>> > +++ b/release/arm64/RPI.conf >>> > -DTB=3D"bcm2710-rpi-2-b.dtb bcm2710-rpi-3-b.dtb = bcm2710-rpi-3-b-plus.dtb >>> bcm2710-rpi-cm3.dtb bcm2711-rpi-4-b.dtb" >>> > +DTB=3D"bcm2710-rpi-2-b.dtb bcm2710-rpi-3-b.dtb = bcm2710-rpi-3-b-plus.dtb >>> bcm2710-rpi-cm3.dtb \ >>> > + bcm2711-rpi-4-b.dtb bcm2711-rpi-cm4-io.dtb = bcm2711-rpi-cm4.dtb >>> bcm2711-rpi-cm4s.dtb" >>>=20 >>> This broke the RPI release build, since bcm2711-rpi-cm4s.dtb = doesn't exist. >>> Is it provided by a port which we should add to the RPI build? >>>=20 >>> I thought it was in tree. I'll look into this and report back. >> Entirely possible. The release-building code is trying to copy it = from >> /usr/local/share/rpi-firmware/bcm2711-rpi-cm4s.dtb >> so if it's somewhere else we need to adjust that code. >=20 > The rpi-firmware port is supposed to provide all .dtb used here, but = we've never installed that one. It really shouldn't have been included = in the list to begin with, but I guess if there's demand we should fix = the port to include it. >=20 > Thanks, >=20 > Kyle Evans we only have tested/fixed the CM4-model, not forceably need the = cm4s.dtb , so no objections to remove cm4s.dtb from the dtb-list at = least temporarily. =20 But please hold cm4.dtb and the cm4_io_.dtb, which will then hopefully = not break the rpi-release anymore.=20 Of course would be better to upgrade the port. thank you Regards Klaus --Apple-Mail=_022483E1-1624-4E13-9994-F726AF53F022 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

Am 25.04.2024 um 22:01 schrieb Kyle Evans = <kevans@FreeBSD.org>:

On 4/25/24 14:43, Colin = Percival wrote:
On 4/25/24 12:24, Warner = Losh wrote:
On Thu, Apr 25, 2024, = 12:57=E2=80=AFPM Colin Percival <cperciva@tarsnap.com = <mailto:cperciva@tarsnap.com>> wrote:
    On = 4/19/24 16:11, Warner Losh wrote:
     >  =     add dtb support for RPI CM4, CM4s, = CM4_ioBoard
     >
     = >      Signed-off-by: Klaus K=C3=BCchemann = <maciphone2@googlemail.com
    = <mailto:maciphone2@googlemail.com>>
     = >      Reviewed by: imp
     = >      Pull Request: = https://github.com/freebsd/freebsd-src/pull/1182
    = <https://github.com/freebsd/freebsd-src/pull/1182>
  &n= bsp;  > ---
     > --- = a/release/arm64/RPI.conf
     > +++ = b/release/arm64/RPI.conf
     > = -DTB=3D"bcm2710-rpi-2-b.dtb bcm2710-rpi-3-b.dtb = bcm2710-rpi-3-b-plus.dtb
    bcm2710-rpi-cm3.dtb = bcm2711-rpi-4-b.dtb"
     > = +DTB=3D"bcm2710-rpi-2-b.dtb bcm2710-rpi-3-b.dtb = bcm2710-rpi-3-b-plus.dtb
    bcm2710-rpi-cm3.dtb = \
     > +    =  bcm2711-rpi-4-b.dtb bcm2711-rpi-cm4-io.dtb = bcm2711-rpi-cm4.dtb
    = bcm2711-rpi-cm4s.dtb"

    This broke the RPI = release build, since bcm2711-rpi-cm4s.dtb doesn't = exist.
    Is it provided by a port which we should = add to the RPI build?

I thought it was in tree. I'll look into = this and report back.
Entirely possible.  The = release-building code is trying to copy it = from
/usr/local/share/rpi-firmware/bcm2711-rpi-cm4s.dtb
so if it's = somewhere else we need to adjust that code.

The = rpi-firmware port is supposed to provide all .dtb used here, but we've = never installed that one.  It really shouldn't have been included = in the list to begin with, but I guess if there's demand we should fix = the port to include it.

Thanks,

Kyle = Evans

we only have tested/fixed the = CM4-model,  not forceably need the cm4s.dtb , so no objections to = remove cm4s.dtb from the dtb-list at least temporarily.  

But please hold cm4.dtb and the = cm4_io_.dtb, which will then hopefully not break the rpi-release = anymore. 

Of course = would be better to upgrade the port.

thank you

Regards

Klaus


= --Apple-Mail=_022483E1-1624-4E13-9994-F726AF53F022--