Date: Wed, 24 May 2006 13:04:03 +0900 From: Takeshi MUTOH <mutoh@openedu.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/97765: [PATCH] lang/ruby18 WITH_PTHREAD handling problem Message-ID: <ddzmh8hxvw.wl%mutoh@openedu.org> Resent-Message-ID: <200605240410.k4O4AL8B010963@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 97765
>Category: ports
>Synopsis: lang/ruby18 default make without pthread, but link -lpthread
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed May 24 04:10:20 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator: Takeshi MUTOH <mutoh@openedu.org>
>Release: FreeBSD 6.1-STABLE i386
>Organization:
OpenEdu.org
>Environment:
FreeBSD mutoh.dyndns.org 6.1-STABLE FreeBSD 6.1-STABLE #1: Sat May 20 22:19:45 JST 2006 root@mutoh.dyndns.org:/usr/obj/usr/src/sys/SMP i386
>Description:
Currently, lang/ruby make without pthread library by default.
But CONFIGURE_ARGS have pthread related entry without pthread related knob,
so binary create with -lpthread.
>How-To-Repeat:
% cd /usr/ports/lang/ruby18
% make
% ldd work/ruby-1.8.4/ruby18
work/ruby-1.8.4/ruby18:
libruby18.so.18 => /usr/local/lib/libruby18.so.18 (0x28074000)
libcrypt.so.3 => /lib/libcrypt.so.3 (0x2812e000)
libm.so.4 => /lib/libm.so.4 (0x28146000)
libpthread.so.2 => /usr/lib/libpthread.so.2 (0x2815c000)
libc.so.6 => /lib/libc.so.6 (0x28181000)
See build log at
http://mutoh.dyndns.org/tmp/ruby-build-old-20060524.log
>Fix:
Please apply patch below.
--- Makefile.org Wed May 24 09:02:28 2006
+++ Makefile Wed May 24 12:24:21 2006
@@ -43,6 +43,8 @@
.if defined(WITH_PTHREADS)
CONFIGURE_ARGS+=--enable-pthread
PKGNAMESUFFIX:= ${PKGNAMESUFFIX}+pthreads
+CFLAGS+=${PTHREAD_CFLAGS}
+LIBS+=${PTHREAD_LIBS}
.else
CONFIGURE_ARGS+=--disable-pthread
.endif
@@ -70,8 +72,8 @@
CONFIGURE_ARGS+= --enable-ipv6
.endif
-CONFIGURE_ENV= CFLAGS="${CFLAGS} ${PTHREAD_CFLAGS}" \
- LIBS="${LIBS} ${PTHREAD_LIBS}"
+CONFIGURE_ENV= CFLAGS="${CFLAGS}" \
+ LIBS="${LIBS}"
.if ${RUBY_VER} == ${RUBY_DEFAULT_VER}
MLINKS= ${RUBY_NAME}.1 ruby.1
--
Takeshi MUTOH <mutoh@openedu.org>
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ddzmh8hxvw.wl%mutoh>