From owner-freebsd-net  Fri Sep 28 13:14:20 2001
Delivered-To: freebsd-net@freebsd.org
Received: from elvis.mu.org (elvis.mu.org [216.33.66.196])
	by hub.freebsd.org (Postfix) with ESMTP id 5166337B40D
	for <net@FreeBSD.ORG>; Fri, 28 Sep 2001 13:14:18 -0700 (PDT)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id E631181D0B; Fri, 28 Sep 2001 15:14:12 -0500 (CDT)
Date: Fri, 28 Sep 2001 15:14:12 -0500
From: Alfred Perlstein <bright@mu.org>
To: jayanth <jayanth@yahoo-inc.com>
Cc: tsuchiya@flab.fujitsu.co.jp, net@FreeBSD.ORG, silby@silby.com,
	jlemon@flugsvamp.com
Subject: Re: TCP performance question
Message-ID: <20010928151412.J59854@elvis.mu.org>
References: <200109270652.PAA03232@const.kawasaki.flab.fujitsu.co.jp> <20010928124325.B36879@yahoo-inc.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <20010928124325.B36879@yahoo-inc.com>; from jayanth@yahoo-inc.com on Fri, Sep 28, 2001 at 12:43:25PM -0700
Sender: owner-freebsd-net@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-net.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-net>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-net>
X-Loop: FreeBSD.org

* jayanth <jayanth@yahoo-inc.com> [010928 14:43] wrote:
> Yoshi,
> I have attached a patch. Let me know if this fixes the problem.
> 
> jayanth

cool, but..

> --- tcp_output.c	Fri Sep 28 11:15:32 2001
> +++ tcp_output.c.new	Fri Sep 28 12:05:03 2001
> @@ -133,7 +133,7 @@
>  	 * If there is some data or critical controls (SYN, RST)
>  	 * to send, then transmit; otherwise, investigate further.
>  	 */
> -	idle = (tp->snd_max == tp->snd_una);
> +	idle = (tp->t_flags & TF_LASTIDLE) ? 1 : (tp->snd_max == tp->snd_una);

how about:
idle = (tp->t_flags & TF_LASTIDLE) || (tp->snd_max == tp->snd_una);

-Alfred

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message