From owner-svn-src-head@FreeBSD.ORG  Sun Sep 22 06:38:33 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 72D712D9;
 Sun, 22 Sep 2013 06:38:33 +0000 (UTC)
 (envelope-from aryeh.friedman@gmail.com)
Received: from mail-pa0-x22f.google.com (mail-pa0-x22f.google.com
 [IPv6:2607:f8b0:400e:c03::22f])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 3D7DC2DD2;
 Sun, 22 Sep 2013 06:38:33 +0000 (UTC)
Received: by mail-pa0-f47.google.com with SMTP id kp14so1048141pab.34
 for <multiple recipients>; Sat, 21 Sep 2013 23:38:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=U3S8RZKoKsHC1tKGpVI9K2Hv99HL09rWywG5vy9Q3ug=;
 b=blaOWVKFggycPTRPD3wlX9dn4PprKiEMZH2bnWEwMIC3+5ruOfFUFEeT4nsh6n2bCH
 p6rBg/nMmm8PaE5D8YAnyqVKYVYmysx9sXsIPvxKcOxGzz/ibG65S+cejPxjd8yIgADL
 dPqK2YsTpbwcJJO98eCb0oo8mh3TzSYb+HTbaRdVKYoer0APPJ0KrmzSGuVoCOTPhjbV
 gLRtdzJeQQBFLfyqL1z4PVv4c27pliahv9hxarHOIFJhFH/ctleXlZHJlZ6shxv13C1w
 Zl+SyzgSo2a4TbKFWl2In725OC1nk7OcXfX4KjOflm6WTXXW/oQvBkR/NpoZMyk40jxP
 wJeA==
MIME-Version: 1.0
X-Received: by 10.68.189.5 with SMTP id ge5mr17378472pbc.42.1379831912825;
 Sat, 21 Sep 2013 23:38:32 -0700 (PDT)
Received: by 10.68.253.162 with HTTP; Sat, 21 Sep 2013 23:38:32 -0700 (PDT)
In-Reply-To: <201309220246.r8M2kEIN054172@svn.freebsd.org>
References: <201309220246.r8M2kEIN054172@svn.freebsd.org>
Date: Sun, 22 Sep 2013 02:38:32 -0400
Message-ID: <CAGBxaX=_DKMFyHBHq4hJtFoGw_K7o=xQzeuh-6NdtFoORJ8XAw@mail.gmail.com>
Subject: Re: svn commit: r255783 - head/sys/kern
From: Aryeh Friedman <aryeh.friedman@gmail.com>
To: "Justin T. Gibbs" <gibbs@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
X-Content-Filtered-By: Mailman/MimeDel 2.1.14
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 22 Sep 2013 06:38:33 -0000

On Sat, Sep 21, 2013 at 10:46 PM, Justin T. Gibbs <gibbs@freebsd.org> wrote:

> Author: gibbs
> Date: Sun Sep 22 02:46:13 2013
> New Revision: 255783
> URL: http://svnweb.freebsd.org/changeset/base/255783
>
> Log:
>   Fix ia64 and mips kernel builds due to XENHVM=>GENERIC integration in
>   revision 255744.
>
>   sys/kern/subr_smp.c:
>         IPI_SUSPEND is only available on amd64 and i386.  Protect
>         new uses of this constant with #ifdefs to avoid impacting
>         other platforms.
>
>   Approved by:  re (blanket Xen)
>
> Modified:
>   head/sys/kern/subr_smp.c
>
> Modified: head/sys/kern/subr_smp.c
>
> ==============================================================================
> --- head/sys/kern/subr_smp.c    Sun Sep 22 02:14:54 2013        (r255782)
> +++ head/sys/kern/subr_smp.c    Sun Sep 22 02:46:13 2013        (r255783)
> @@ -225,6 +225,7 @@ generic_stop_cpus(cpuset_t map, u_int ty
>         CTR2(KTR_SMP, "stop_cpus(%s) with %u type",
>             cpusetobj_strprint(cpusetbuf, &map), type);
>
> +#if defined(__amd64__) || defined(__i386__)
>         /*
>          * When suspending, ensure there are are no IPIs in progress.
>          * IPIs that have been issued, but not yet delivered (e.g.
> @@ -234,6 +235,7 @@ generic_stop_cpus(cpuset_t map, u_int ty
>          */
>         if (type == IPI_SUSPEND)
>                 mtx_lock_spin(&smp_ipi_mtx);
> +#endif
>
>         if (stopping_cpu != PCPU_GET(cpuid))
>                 while (atomic_cmpset_int(&stopping_cpu, NOCPU,
> @@ -262,8 +264,10 @@ generic_stop_cpus(cpuset_t map, u_int ty
>                 }
>         }
>
> +#if defined(__amd64__) || defined(__i386__)
>         if (type == IPI_SUSPEND)
>                 mtx_unlock_spin(&smp_ipi_mtx);
> +#endif
>
>         stopping_cpu = NOCPU;
>         return (1);
> _______________________________________________
> svn-src-all@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/svn-src-all
> To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
>


This seems to cause a kernel panic if the machine is left idle for too long