From owner-cvs-all Fri Sep 6 12:59:34 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 607A437B400; Fri, 6 Sep 2002 12:59:30 -0700 (PDT) Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 260B443E3B; Fri, 6 Sep 2002 12:59:30 -0700 (PDT) (envelope-from peter@FreeBSD.org) Received: from freefall.freebsd.org (peter@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.4/8.12.4) with ESMTP id g86JxUJU019218; Fri, 6 Sep 2002 12:59:30 -0700 (PDT) (envelope-from peter@freefall.freebsd.org) Received: (from peter@localhost) by freefall.freebsd.org (8.12.4/8.12.4/Submit) id g86JxTS9019217; Fri, 6 Sep 2002 12:59:29 -0700 (PDT) Message-Id: <200209061959.g86JxTS9019217@freefall.freebsd.org> From: Peter Wemm Date: Fri, 6 Sep 2002 12:59:29 -0700 (PDT) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sbin/mount_nfs mount_nfs.c X-FreeBSD-CVS-Branch: HEAD Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG peter 2002/09/06 12:59:29 PDT Modified files: sbin/mount_nfs mount_nfs.c Log: Bandaid for mount_nfs segfaulting with the more obscure mount options in /etc/fstab. This isn't a real fix though and I'm still not sure why it started failing. mount(8) breaks up the nfs args into seperate repeated '-o option=value' arguments. But, the altflags variable that we use to track things is incrementally built up each time we see the next option and shows us the cumulative set of flags, not just the flag that we are currently looking at. As a result, the strstr hack for looking up flags in a giant -o opt=val,opt=val, etc string was failing and causing a segfault. I do not know what changed recently that caused this to suddenly break, but the code has been rather bogus for some time. Revision Changes Path 1.56 +34 -22 src/sbin/mount_nfs/mount_nfs.c To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message