From owner-svn-src-head@freebsd.org Mon Dec 10 06:40:44 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2C68613137ED; Mon, 10 Dec 2018 06:40:44 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 155076A1D2; Mon, 10 Dec 2018 06:40:42 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id WFF8g0a23ctraWFF9g9qv2; Sun, 09 Dec 2018 23:40:41 -0700 X-Authority-Analysis: v=2.3 cv=Io3Pj43g c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=kj9zAlcOel0A:10 a=2ur7OfE09M0A:10 a=iKhvJSA4AAAA:8 a=ypVJL4-jAAAA:8 a=7Qk2ozbKAAAA:8 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=PGztigdreN4GuxPxX5EA:9 a=CjuIK1q_8ugA:10 a=odh9cflL3HIXMm4fY7Wr:22 a=khIbc0fXALFIcTpOSxgJ:22 a=1lyxoWkJIXJV6VJUPhuM:22 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 20B771F6B; Sun, 9 Dec 2018 22:40:37 -0800 (PST) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id wBA6eabO052007; Sun, 9 Dec 2018 22:40:36 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id wBA6eaMA052004; Sun, 9 Dec 2018 22:40:36 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201812100640.wBA6eaMA052004@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: rgrimes@freebsd.org cc: Warner Losh , Oliver Pinter , svn-src-head@freebsd.org, Cy Schubert , svn-src-all@freebsd.org, src-committers , Cy Schubert Subject: Re: svn commit: r341759 - in head: contrib/wpa contrib/wpa/hostapd contrib/wpa/hs20/client contrib/wpa/src/ap contrib/wpa/src/common contrib/wpa/src/crypto contrib/wpa/src/drivers contrib/wpa/src/eap_c... In-Reply-To: Message from "Rodney W. Grimes" of "Sun, 09 Dec 2018 22:19:11 -0800." <201812100619.wBA6JB0c064609@pdx.rh.CN85.dnsmgr.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sun, 09 Dec 2018 22:40:36 -0800 X-CMAE-Envelope: MS4wfHZK4qAssYBM9PgRRI+w13DiwpGEPnffBBWp8oslN0nMtIedU8dAi0/mN60j8KBXBR0HII0Eld7Xsuw4VDO09NbhBnkkP/ifUU86s3xeyFB4foy7nX2L BB5pXEOKFyDv800JyTddAJZEfJqq3z5XnbwpfcasGFFCYkrayp+UdPg74yyZlWxYaNl7J1Pn0BeMIxTQOvDBwv/fbTy6WSyDJk+8XxXB5DDrLwPMCadrLqU4 +9FqECUK9LkUfxFSd/LKB/C+PSK5T7ofq77Jjk0I0LczBOcWC3JuDRD9X0uR2Yv7oTtipRzPr+vbQ82Yl3z1jADtgcNDhx/VbctkRn7Pv3l2a7K8imwoHxGM xUXjwJHl6VT2vIVaH3wxEbvHpoC/+w== X-Rspamd-Queue-Id: 155076A1D2 X-Spamd-Result: default: False [-2.97 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; RECEIVED_SPAMHAUS_PBL(0.00)[17.125.67.70.zen.spamhaus.org : 127.0.0.11]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; LONG_SUBJ(1.52)[203]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[cached: spqr.komquats.com]; REPLYTO_EQ_FROM(0.00)[]; RCPT_COUNT_SEVEN(0.00)[8]; NEURAL_HAM_SHORT(-0.91)[-0.915,0]; NEURAL_HAM_MEDIUM(-1.00)[-0.996,0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:6327, ipnet:64.59.128.0/20, country:CA]; IP_SCORE(-1.87)[ip: (-4.12), ipnet: 64.59.128.0/20(-2.85), asn: 6327(-2.28), country: CA(-0.09)]; RCVD_IN_DNSWL_LOW(-0.10)[138.136.59.64.list.dnswl.org : 127.0.5.1] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Dec 2018 06:40:44 -0000 In message <201812100619.wBA6JB0c064609@pdx.rh.CN85.dnsmgr.net>, "Rodney W. Gri mes" writes: > > On Sun, Dec 9, 2018 at 2:03 PM Oliver Pinter > > > wrote: > > > > > > > > > > > On Sunday, December 9, 2018, Warner Losh wrote: > > > > > >> On Sun, Dec 9, 2018 at 1:09 PM Rodney W. Grimes < > > >> freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > >> > > >> > > In message <201812090645.wB96jnso066329@repo.freebsd.org>, Cy > > >> Schubert > > >> > > writes: > > >> > > > Author: cy > > >> > > > Date: Sun Dec 9 06:45:49 2018 > > >> > > > New Revision: 341759 > > >> > > > URL: https://svnweb.freebsd.org/changeset/base/341759 > > >> > > > > > >> > > > Log: > > >> > > > MFV r341618: > > >> > > > > > >> > > > Update wpa 2.6 --> 2.7. > > >> > > > > >> > > Relnotes: yes > > >> > > > >> > As an FYI, or maybe a new procedure, doing a reply to > > >> > a commit message adding relnotes: yes does very little > > >> > to insure that this commit gets refered to in release > > >> > notes. > > >> > > > >> > What about we add RELNOTES.missed to the tree > > >> > next to UPDATING, and when someone forgets to tag > > >> > the Relnotes:yes into a commit you just follow up > > >> > with a commit to that file, stating the svn revision > > >> > which was missing the note and then we have a nice > > >> > documented and clean way to extract the missing > > >> > release note items, rather than trying to cull it > > >> > from a thread in a mail list archive. > > >> > > > >> > The file would get truncated to 0 at appropriate > > >> > times on various branches. > > >> > > > >> > > >> How about just RELNOTES. You put the revision that is relevant and a qui > ck > > >> blurb. That way we don't have to look in two places. All release notes g > o > > >> in here, no exceptions. You can retroactively tag them, or you can commi > t > > >> this as part of commit. > > My one concern is that if we remove the Relnotes: yes line > from the commits then we may end up totally ignoring the > need to put entries in RELNOTES, which unlike UPDATING > do not have consequences if ignored. > > > > > > > > > >> > > > I don't really know SVN, but there wouldn't be a chicken egg probem durin > g > > > commit time? I mean you would really know the SVN id. So you could only a > dd > > > a specific revision in a different commit to RELEASE file. > > > > > > > Generally, you can guess really well, and fix it in the case of a lost race > > easily. > > No reason to guess, if you add the RELNOTES change with the commit > then it is the revision that added the RELNOTES entry, so a log view > of RELNOTES would show you the revision. If you do it after words > or edit an existing entry in the RELNOTES file that is also fairly > clear as that commit has no other files touched. > > > > > You'd add the release notes text in full to the file, with a pointer to the > > revision(s) for the feature. > > If you modify RELNOTES with the commit adding the feature we > could easily use a pointer of "this commit", the svn version number > of that added entry is self referencing to the actual change, > which I actually rather like the idea of. > > > > > Warner > > > > > > > >> Have a blurb at the top that tells people what > > >> order to add them in, and you'd be set. We'd then retire "relnotes: yes" > > >> in > > >> the commit message. This would also allow 'helpers' to format the RELNOT > ES > > >> file as we go rather than having to play 2 years of catch-up at major > > >> branch times. > > Yes. You could actually "delete" an entry from RELNOTES once a > proper entry in the actual release notes had been created, such > that RELNOTES is really a list of pending items. > > > >> > > >> Having it in the commit message just doesn't work, and this is one of ma > ny > > >> reasons: Cy forgot. Other times I'll do something and it's only a month > > >> later I realize it needs to be in the release notes after some issue has > > >> come up.... Other times I put relnotes: yes in only to realize that's my > > >> vanity talking, and nobody else cares. > > I agree, what we have now works poorly. Forgetting, yes, but also a hmmm moment. Initially my thinking was a file in doc/. Or maybe something like the vuxml port where we fill in the blanks and make validate to make sure all the i's are dotted and t's crossed. It's a little extra work for committers but would help re@ immensely, and get the details in from the get-go. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.