From nobody Sun Jan 11 05:10:28 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dpk9h5T3lz6NTb5 for ; Sun, 11 Jan 2026 05:10:48 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dpk9g5zjfz3K4R for ; Sun, 11 Jan 2026 05:10:47 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20230601 header.b=YdKO+WQK; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::62b as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-2a1388cdac3so38807045ad.0 for ; Sat, 10 Jan 2026 21:10:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768108241; x=1768713041; darn=freebsd.org; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=UeJq0rFG33VmsIbp1EpjG01cxk+cWQ39XBgyxiVY50Q=; b=YdKO+WQKg2wsNKNuPKCsUcA1E8krAlzryn7MQGM3SuOayDfqpu3lH9yR5nRU7tuHKP LCQEiEbblVZhkYh7AUM58cZy3bYIjBBVki/fM44I9i+jYDGfbY8f6bLw1i5gHeuOaoZW FXScobLkV/qM+IFJF6qA/vrJdcuTTx0Kc2W06j6OcglFv0vcS+5eRMGm11s2X8QMlfI0 2J7P9fsfiCHYNeEOIAGoWVTDljPaHVVCaKO7MERSmNQEyCfDT+TgEizUDac1/S+fOKgJ 49iGI24j3/gvjOaIIXibDB1V/1VfBV2dT1zI/N25cF95lzx7tFjjqwvfqv08Tz2s1xaL a+YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768108241; x=1768713041; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UeJq0rFG33VmsIbp1EpjG01cxk+cWQ39XBgyxiVY50Q=; b=HeZ2OiyNn9q8MatD+zocOEgtpyr4031Fp0elioTrbiV8KRde0MGh/6NuoeoVz9zGE8 peAoLf0LkL22hitGSqY/cQJojWHPR3NwJjWFVVr8nCp2+maJyevlQFglA6efRkdmlNnJ qtaOn0P0oDtRfl+KNcq+xgCpQYC2EXLNvFCRMyzc57JgQfp3tpepJFblNw9SBhFa8fa9 MfvDnQlZLIRa6soppmBjRF+5qGKb5hE5cS8VUJlGFfnzWgWw1MhbIm4koSTpGrjXUNI1 Wg/KBuO4BZRyxgnSOHftGNDr376GACeftZUPqjdHhWUOKijvebLfEsmZFRmWZgp10OUo DcVQ== X-Forwarded-Encrypted: i=1; AJvYcCUFpt7RS8oDfsyK64YAmy6SVEkJrmS58QUu+TlUR9mOiIp+IzoBxFn2XPh8ah22L+bpfSD7VvfbsZulOp99NMhTQNB5BA==@freebsd.org X-Gm-Message-State: AOJu0YxP1dOl5dNgMxIoZusGj4eCh+EE4mSV/JGZ35LR4KjoEaleVg3x LMc/Q0Ly06yq6ecEbsAoIYP5oWiX0XPbqXallTAXcJAn0o+d+xmTC5TO X-Gm-Gg: AY/fxX5+VgNVCIxdlU2dK1H90hfDlvBGyBvDwMRWIL5oLuduwsCdSYJ7HIkZsogidyp bnBmmMwwwIgUWEBMf0kkmLAkTsIakyhZhAMaBrXbhq+7cPt9uiw3hAxCdyEmd4sWxXNcTPL1GIs 2B4jUNbPNXUl6L8fLw2pMEFMLI29uj/YtjJCW7cLdiGxPaGEcAd+NAUUwxCGoL1qs++PlKM48jt EmCbmDKCb444q6D0dGJL/xhDy2svccaOhw486Rbs7tKG4LU8XMag9UE9BMgtUCmMbbLyyckzXmP RV697eFEEAKElYsKfM60Tzj2kACh2papBmLsnCrK+mCB5C60n+snFV3QnSEnGKzb5vMJSN8GcPf JkweSsc9uzyPu34Zf3QA/gj55ujHy433FzajCF6iecdcZhu7uAkAh1s3sW6pMfYITn6W7g5bRz6 JUSupLjkkSNpG/gw/78Y3MkvavdcM= X-Google-Smtp-Source: AGHT+IGVXbv0akI8kqQwmJPkSvxsGe+ek8HNTjHXEVVB1L1HF5NQT9NlFqMts4A1j7zXzzvmgNJQcw== X-Received: by 2002:a17:902:f546:b0:290:ac36:2ed6 with SMTP id d9443c01a7336-2a3ee42a386mr129843315ad.14.1768108241370; Sat, 10 Jan 2026 21:10:41 -0800 (PST) Received: from smtpclient.apple ([45.90.222.74]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3c3a512sm142853965ad.10.2026.01.10.21.10.40 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 10 Jan 2026 21:10:40 -0800 (PST) From: "Enji Cooper (yaneurabeya)" Message-Id: Content-Type: multipart/alternative; boundary="Apple-Mail=_E171B85B-34E5-4F71-8E48-63CE71FBE9CB" List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81.1.4\)) Subject: Re: git: f224591746bd - main - Add ASMC_DEBUG make option Date: Sat, 10 Jan 2026 21:10:28 -0800 In-Reply-To: <1990810.vR5SVPPSqJ@ravel> Cc: Enji Cooper , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org To: Olivier Certner References: <695c68c6.3ff5d.593fc2c7@gitrepo.freebsd.org> <1990810.vR5SVPPSqJ@ravel> X-Mailer: Apple Mail (2.3826.700.81.1.4) X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.36 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.86)[-0.856]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; MV_CASE(0.50)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20230601]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; TO_DN_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; FREEMAIL_ENVFROM(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ARC_NA(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; FROM_HAS_DN(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::62b:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; MID_RHS_MATCH_FROM(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_FIVE(0.00)[5] X-Rspamd-Queue-Id: 4dpk9g5zjfz3K4R --Apple-Mail=_E171B85B-34E5-4F71-8E48-63CE71FBE9CB Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hi Olivier, > On Jan 9, 2026, at 8:44=E2=80=AFAM, Olivier Certner = wrote: >=20 > Hi Enji, >=20 >> The branch main has been updated by ngie: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3Df224591746bdaf14ad5f63de4738a314= 6cc2f55f >>=20 >> commit f224591746bdaf14ad5f63de4738a3146cc2f55f >> Author: Enji Cooper >> AuthorDate: 2026-01-04 08:27:57 +0000 >> Commit: Enji Cooper >> CommitDate: 2026-01-06 01:43:04 +0000 >>=20 >> Add ASMC_DEBUG make option >=20 > This commit broke the i386 build. I've just committed a fix. Also, = I've restored 'device vt_efifb' in NOTES (under 'x86/' instead of = 'amd64/'), as AFAIK, NOTES should list all possible devices/options. re: vt_efifb: what I did was removed the duplicate entry, since it was = already in the x86 one: = https://cgit.freebsd.org/src/tree/sys/x86/conf/NOTES#n332 . > Please make sure you also MFC the two following commits (67599eef01f5 = ("sys/x86/NOTES: Add vt_efifb"), fde9fe18219f i386 ("Fix kernel = compilation after introduction of ASMC_DEBUG option")) along with the = original one. Sure =E2=80=94 although the correct fix would be to not build the driver = at all on i386, since it doesn=E2=80=99t support 32-bit CPUs. Apple sold = very few i386-based Intel chips before they transitioned to amd64-only = ones (it was only a matter of 8-9 months IIRC) and asmc(4) doesn=E2=80=99t= support any of the 32-bit chips (I checked). Cheers, -Enji= --Apple-Mail=_E171B85B-34E5-4F71-8E48-63CE71FBE9CB Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 Hi = Olivier,

On Jan 9, 2026, at = 8:44=E2=80=AFAM, Olivier Certner <olce@freebsd.org> = wrote:

Hi = Enji,

The branch main has been updated = by ngie:

URL: = https://cgit.FreeBSD.org/src/commit/?id=3Df224591746bdaf14ad5f63de4738a314= 6cc2f55f

commit = f224591746bdaf14ad5f63de4738a3146cc2f55f
Author: =     Enji Cooper = <ngie@FreeBSD.org>
AuthorDate: 2026-01-04 08:27:57 = +0000
Commit:     Enji Cooper = <ngie@FreeBSD.org>
CommitDate: 2026-01-06 01:43:04 = +0000

   Add ASMC_DEBUG make = option

This commit broke the i386 build.  I've = just committed a fix.  Also, I've restored 'device vt_efifb' in = NOTES (under 'x86/' instead of 'amd64/'), as AFAIK, NOTES should list = all possible = devices/options.

re: = vt_efifb: what I did was removed the duplicate entry, since it was = already in the x86 one: https:/= /cgit.freebsd.org/src/tree/sys/x86/conf/NOTES#n332 .
Please make sure you also MFC the two = following commits (67599eef01f5 ("sys/x86/NOTES: Add vt_efifb"), = fde9fe18219f i386 ("Fix kernel compilation after introduction of = ASMC_DEBUG option")) along with the original = one.

Sure =E2=80=94 although the = correct fix would be to not build the driver at all on i386, since it = doesn=E2=80=99t support 32-bit CPUs. Apple sold very few i386-based = Intel chips before they transitioned to amd64-only ones (it was only a = matter of 8-9 months IIRC) and asmc(4) doesn=E2=80=99t support any of = the 32-bit chips (I = checked).
Cheers,
-Enji
= --Apple-Mail=_E171B85B-34E5-4F71-8E48-63CE71FBE9CB--