From owner-p4-projects@FreeBSD.ORG Thu Jul 29 18:01:39 2004 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 817AD16A4D1; Thu, 29 Jul 2004 18:01:39 +0000 (GMT) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4C06A16A4CE for ; Thu, 29 Jul 2004 18:01:39 +0000 (GMT) Received: from mail2.speakeasy.net (mail2.speakeasy.net [216.254.0.202]) by mx1.FreeBSD.org (Postfix) with ESMTP id 15EE443D67 for ; Thu, 29 Jul 2004 18:01:39 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 31622 invoked from network); 29 Jul 2004 18:01:38 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 29 Jul 2004 18:01:38 -0000 Received: from 10.50.40.208 (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id i6TI1YFv089339; Thu, 29 Jul 2004 14:01:34 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: "Justin T. Gibbs" Date: Thu, 29 Jul 2004 14:01:33 -0400 User-Agent: KMail/1.6 References: <200407282050.i6SKo9ci010595@repoman.freebsd.org> In-Reply-To: MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200407291401.33538.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: Perforce Change Reviews Subject: Re: PERFORCE change 58403 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jul 2004 18:01:40 -0000 On Wednesday 28 July 2004 06:57 pm, Justin T. Gibbs wrote: > > http://perforce.freebsd.org/chv.cgi?CH=58403 > > > > Change 58403 by jhb@jhb_slimer on 2004/07/28 20:49:40 > > > > Prompted by some questions on IRC from gibbs@, scottl@, and others: > > atomic_store_rel() on ia32 does not actually need a lock > > ... > > > Differences ... > > > > ==== //depot/projects/smpng/sys/i386/include/atomic.h#13 (text+ko) ==== > > > > @@ -180,7 +180,7 @@ > > * XXX: This is _NOT_ safe on a P6 or higher because it does not > > guarantee * memory ordering. These should only be used on a 386. > > */ > > Is the above comment still accurate? For the load_acq, yes. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org