From owner-svn-src-all@freebsd.org  Fri Nov 20 23:20:26 2015
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id BB515A334F5
 for <svn-src-all@mailman.ysv.freebsd.org>;
 Fri, 20 Nov 2015 23:20:26 +0000 (UTC)
 (envelope-from mailing-machine@vniz.net)
Received: from mail-lb0-f179.google.com (mail-lb0-f179.google.com
 [209.85.217.179])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4A9011A6B
 for <svn-src-all@freebsd.org>; Fri, 20 Nov 2015 23:20:25 +0000 (UTC)
 (envelope-from mailing-machine@vniz.net)
Received: by lbbcs9 with SMTP id cs9so70109803lbb.1
 for <svn-src-all@freebsd.org>; Fri, 20 Nov 2015 15:20:18 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:subject:to:references:from:message-id:date
 :user-agent:mime-version:in-reply-to:content-type
 :content-transfer-encoding;
 bh=n0p3mVY8VM823BwU+YyXnhmeCbuai0zQwayqqhAC3gs=;
 b=YSVhbnRE+LeIhKKl2DvKWcoxdq7fbEWQ2s6Nj5y0pMAFqr/zDCFF+VKC9lR2GP1daM
 siKhHX2zHptwtKr9cYNn2+GxBIO40W0GjDXZIn7Ems5GDKrkBnhiKr0gwxUOSXhKJXQW
 RM/q+E7ln1nGXA20GySIg8/LOLcI8whfk5uhqMWnkJgO22qy/w2LUwvwyM2mZ2TDwiok
 51zLTEu09LTWcri6NptbZM76dAxknDGYNaViaA86aqP3oMz/TIg9yDzKQ0yXR/1x7Cby
 6Xs8uvwbICxorA23u2IgmOY5CAIVSRFTpGYtcvg1na2p3i3cBbsF49SbTTSq31ixPPVO
 rGoA==
X-Gm-Message-State: ALoCoQmQpbdoN+8YASOsffevDhs6CB5DM0RLIGg/3ZgTsK0X8WeJAD2eunV1yFACZARB6qaYP9xB
X-Received: by 10.112.134.169 with SMTP id pl9mr6746570lbb.145.1448061618269; 
 Fri, 20 Nov 2015 15:20:18 -0800 (PST)
Received: from [192.168.1.2] ([89.169.173.68])
 by smtp.gmail.com with ESMTPSA id li2sm204859lbc.37.2015.11.20.15.20.17
 (version=TLSv1/SSLv3 cipher=OTHER);
 Fri, 20 Nov 2015 15:20:17 -0800 (PST)
Subject: Re: svn commit: r291114 - head/lib/libc/gen
To: Ravi Pokala <rpokala@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
References: <201511202236.tAKMaf06048447@repo.freebsd.org>
From: Andrey Chernov <ache@freebsd.org>
Message-ID: <564FAAB0.6000600@freebsd.org>
Date: Sat, 21 Nov 2015 02:20:16 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <201511202236.tAKMaf06048447@repo.freebsd.org>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Nov 2015 23:20:26 -0000

On 21.11.2015 1:36, Ravi Pokala wrote:
>   Move fdopen() up near other resource allocation like malloc(); do proper
>   deallocation on failure later on in the function.

Incorrect. Old code calls fdopen() only in the parent, new one calls
fdopen() before fork(), so its results shared by both parent and child,
which is wrong for child() case.

-- 
http://ache.vniz.net/