From owner-cvs-all@FreeBSD.ORG Fri Jun 23 01:15:28 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C550916A504; Fri, 23 Jun 2006 01:15:27 +0000 (UTC) (envelope-from marcel@xcllnt.net) Received: from ns1.xcllnt.net (209-128-86-226.bayarea.net [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 450A543D5D; Fri, 23 Jun 2006 01:15:18 +0000 (GMT) (envelope-from marcel@xcllnt.net) Received: from [192.168.4.150] (pptp0.pn.xcllnt.net [192.168.4.150]) by ns1.xcllnt.net (8.13.6/8.13.6) with ESMTP id k5N1FF4w058029; Thu, 22 Jun 2006 18:15:17 -0700 (PDT) (envelope-from marcel@xcllnt.net) In-Reply-To: <449B2F10.2020808@FreeBSD.org> References: <200606222222.k5MMMWTj017990@repoman.freebsd.org> <449B2F10.2020808@FreeBSD.org> Mime-Version: 1.0 (Apple Message framework v750) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <44CD89F0-FEB9-4F6E-AD2D-B076A36CBABA@xcllnt.net> Content-Transfer-Encoding: 7bit From: Marcel Moolenaar Date: Thu, 22 Jun 2006 18:15:12 -0700 To: Maxim Sobolev X-Mailer: Apple Mail (2.750) Cc: cvs-src@FreeBSD.org, Marcel Moolenaar , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sbin/gpt gpt.8 gpt.c show.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jun 2006 01:15:28 -0000 On Jun 22, 2006, at 5:00 PM, Maxim Sobolev wrote: > Marcel Moolenaar wrote: >> marcel 2006-06-22 22:22:32 UTC >> FreeBSD src repository >> Modified files: >> sbin/gpt gpt.8 gpt.c show.c Log: >> Improve support for Intel based Macs: >> o Accept hfs as partition type. >> o Print Apple HFS partitions using a friendly name. > > While we are on subject, I have a patch which makes geom_gpt > friendly to the disks partitioned using BootCamp. Basically, for > compatibility with non-GPT operating systems, BootCamp creates > three records in the MBR: one GPT protective, covering the whole > unit, the second one for HFS and the third one for non-Apple > operating system. However, since geom_gpt considers protective MBR > to be invalid unless it's the only valid MBR record, it doesn't > attaches to such disk. > > Do you have any objections to lifting such check? I don't mind changing geom_gpt to work for Intel based Macs, but I'd like to avoid simply removing checks and thus accepting just about anything. I'd like to keep the checks strict enough that we don't try to interpret garbage as partition information. If we allow the PMBR to have actual partitions, I'd like to extend the checks to cover the partition information itself. For example, we now check that the table only has partitions of type 0xEE (if at all). This is a sloppy test by any standard. If we allow "normal" partitions, I'd like to enforce that there's exactly 1 partition of type 0xEE and it covers the whole disk. This way we make sure that it's still pretty much a PMBR by intend, even though it really is used as an MBR. Does that sound reasonable to you? -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net