From owner-svn-src-head@freebsd.org Sat Jun 2 23:53:10 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6239CFD1A65; Sat, 2 Jun 2018 23:53:10 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C4D068169C; Sat, 2 Jun 2018 23:53:09 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w52Nr1OD088637; Sat, 2 Jun 2018 16:53:01 -0700 (PDT) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w52Nr1LA088636; Sat, 2 Jun 2018 16:53:01 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201806022353.w52Nr1LA088636@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r334540 - head/usr.bin/top In-Reply-To: <201806022140.w52LejjF005616@repo.freebsd.org> To: Eitan Adler Date: Sat, 2 Jun 2018 16:53:01 -0700 (PDT) CC: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Jun 2018 23:53:10 -0000 [ Charset UTF-8 unsupported, converting... ] > Author: eadler > Date: Sat Jun 2 21:40:45 2018 > New Revision: 334540 > URL: https://svnweb.freebsd.org/changeset/base/334540 > > Log: > top(1): cleanup memory allocation and warnings > > - Prefer calloc over malloc. This is more predicable and we're not in a > performance sensitive context. [1] > - Remove bogus comment (obsolete from prior commit). [2] > - Remove void casts and type casts of NULL > - Remove redundant declaration of 'quit' > - Add additional const > > Reported by: kib [1], vangyzen [2] > > Modified: > head/usr.bin/top/display.c > head/usr.bin/top/machine.c > head/usr.bin/top/screen.c > head/usr.bin/top/screen.h > head/usr.bin/top/utils.c ... > > Modified: head/usr.bin/top/screen.c > ============================================================================== > --- head/usr.bin/top/screen.c Sat Jun 2 21:16:20 2018 (r334539) > +++ head/usr.bin/top/screen.c Sat Jun 2 21:40:45 2018 (r334540) > @@ -3,7 +3,7 @@ > * Version 3 > * > * This program may be freely redistributed, > - * but this entire comment MUST remain intact. > + * but this entire ceomment MUST remain intact. I know you have already fixed this spelling error, but I believe there are some other commits that actually removed either this string, or some part of "this entire" comment that is to "remain intact". Regards, -- Rod Grimes rgrimes@freebsd.org