From owner-svn-src-user@freebsd.org Tue Jan 12 22:42:52 2016 Return-Path: Delivered-To: svn-src-user@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 987A3A6D372 for ; Tue, 12 Jan 2016 22:42:52 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 89B4C19F2; Tue, 12 Jan 2016 22:42:52 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id 818F1191C; Tue, 12 Jan 2016 22:42:52 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 4ABC314F92; Tue, 12 Jan 2016 22:42:52 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id 83NBGLu7ZxsL; Tue, 12 Jan 2016 22:42:49 +0000 (UTC) Subject: Re: svn commit: r293777 - user/cperciva/freebsd-update-build/scripts DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 5AFD214F8C To: Gleb Smirnoff , Devin Teske References: <201601121806.u0CI67gI009531@repo.freebsd.org> <20160112180805.GP1906@FreeBSD.org> <1452622770.11054.1.camel@FrauBSD.org> <20160112223641.GU1906@FreeBSD.org> <5695813F.9090803@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-user@freebsd.org From: Bryan Drewery Organization: FreeBSD Message-ID: <56958168.8090503@FreeBSD.org> Date: Tue, 12 Jan 2016 14:42:48 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <5695813F.9090803@FreeBSD.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jan 2016 22:42:52 -0000 On 1/12/16 2:42 PM, Bryan Drewery wrote: > On 1/12/16 2:36 PM, Gleb Smirnoff wrote: >> On Tue, Jan 12, 2016 at 10:19:30AM -0800, Devin Teske wrote: >> D> On Tue, 2016-01-12 at 10:08 -0800, Gleb Smirnoff wrote: >> D> > On Tue, Jan 12, 2016 at 06:06:07PM +0000, Gleb Smirnoff wrote: >> D> > T> Author: glebius >> D> > T> Date: Tue Jan 12 18:06:07 2016 >> D> > T> New Revision: 293777 >> D> > T> URL: https://svnweb.freebsd.org/changeset/base/293777 >> D> > T> >> D> > T> Log: >> D> > T> Adjust script removing .orig files and empty files: >> D> > T> - Adopt the regexp to cleaned patches, that don't have >> D> > T> diff or subversion header. >> D> > T> - Switch from awk to sed, due to bugs in awk regexps. >> D> > >> D> > If anyone interested, in our awk regexp "^diff" would match >> D> > " diff", any amount of whitespace. Since ntp has a lot >> D> > variables named diff, running the script over ntp patches >> D> > produce a lot of garbage. >> D> > >> D> >> D> Gleb, I can't seem to reproduce what you're saying. >> D> >> D> $ echo " diff" | awk '/^diff/' >> D> $ echo " diff" | awk '!/^diff/' >> D> diff >> >> echo " diff" | awk '$1 ~ /^diff/ { print $NF }' >> > > That's not a bug. $1 is "diff". > $0 is the whole line: # echo " blah"|awk '{print $1}' blah # echo " blah"|awk '{print $0}' blah -- Regards, Bryan Drewery