From owner-svn-src-head@freebsd.org Thu Jun 14 09:06:54 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 67212101396F; Thu, 14 Jun 2018 09:06:54 +0000 (UTC) (envelope-from tsoome@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 158847EEB7; Thu, 14 Jun 2018 09:06:54 +0000 (UTC) (envelope-from tsoome@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id E622526563; Thu, 14 Jun 2018 09:06:53 +0000 (UTC) (envelope-from tsoome@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id w5E96r2w041126; Thu, 14 Jun 2018 09:06:53 GMT (envelope-from tsoome@FreeBSD.org) Received: (from tsoome@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id w5E96rA4041125; Thu, 14 Jun 2018 09:06:53 GMT (envelope-from tsoome@FreeBSD.org) Message-Id: <201806140906.w5E96rA4041125@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: tsoome set sender to tsoome@FreeBSD.org using -f From: Toomas Soome Date: Thu, 14 Jun 2018 09:06:53 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r335126 - head/stand/libsa X-SVN-Group: head X-SVN-Commit-Author: tsoome X-SVN-Commit-Paths: head/stand/libsa X-SVN-Commit-Revision: 335126 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jun 2018 09:06:54 -0000 Author: tsoome Date: Thu Jun 14 09:06:53 2018 New Revision: 335126 URL: https://svnweb.freebsd.org/changeset/base/335126 Log: libsa: f_rabuf could be NULL It is possible that we will not get RA buffer from open(), therefore we must validate RA. Modified: head/stand/libsa/read.c Modified: head/stand/libsa/read.c ============================================================================== --- head/stand/libsa/read.c Thu Jun 14 08:58:10 2018 (r335125) +++ head/stand/libsa/read.c Thu Jun 14 09:06:53 2018 (r335126) @@ -108,7 +108,7 @@ read(int fd, void *dest, size_t bcount) } /* will filling the readahead buffer again not help? */ - if (resid >= SOPEN_RASIZE) { + if (f->f_rabuf == NULL || resid >= SOPEN_RASIZE) { /* * bypass the rest of the request and leave the * buffer empty