From owner-freebsd-current  Mon Sep  9 17:56:42 2002
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id A65FD37B400; Mon,  9 Sep 2002 17:56:40 -0700 (PDT)
Received: from gw.catspoiler.org (217-ip-163.nccn.net [209.79.217.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 3172D43E3B; Mon,  9 Sep 2002 17:56:40 -0700 (PDT)
	(envelope-from dl-freebsd@catspoiler.org)
Received: from mousie.catspoiler.org (mousie.catspoiler.org [192.168.101.2])
	by gw.catspoiler.org (8.12.5/8.12.5) with ESMTP id g8A0uQwr093581;
	Mon, 9 Sep 2002 17:56:30 -0700 (PDT)
	(envelope-from dl-freebsd@catspoiler.org)
Message-Id: <200209100056.g8A0uQwr093581@gw.catspoiler.org>
Date: Mon, 9 Sep 2002 17:56:26 -0700 (PDT)
From: Don Lewis <dl-freebsd@catspoiler.org>
Subject: Re: vnode lock assertion problem in nfs_link()
To: rwatson@FreeBSD.org
Cc: current@FreeBSD.org, jeff@FreeBSD.org
In-Reply-To: <Pine.NEB.3.96L.1020909200649.4317A-100000@fledge.watson.org>
MIME-Version: 1.0
Content-Type: TEXT/plain; charset=US-ASCII
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

On  9 Sep, Robert Watson wrote:
> On Mon, 9 Sep 2002, Don Lewis wrote:

>> I think we can probably just lock and unlock vp around the call to
>> VOP_FSYNC() ...
> 
> What I'd actually like to do is lock vp on going in to the VOP.  I need to
> grab the lock in the link() code anyway to do the MAC check.  UFS and
> others all immediately lock the vnode on entry anyway...

That sounds reasonable.  It looks like ufs and ext2fs are currently
doing the locking and nfs and coda aren't.  The only other filesystem
that implements the link method is unionfs, which conditionally does the
lock only in certain cases and does some complex lock manipulations that
I don't fully understand.

BTW, I noticed that a number of filesystems have reimplemented
vop_eopnotsupp() and called it foofs_link().


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message