From owner-freebsd-net  Wed Apr 26 12:49:56 2000
Delivered-To: freebsd-net@freebsd.org
Received: from dustdevil.waterspout.com (fourier.physics.purdue.edu [128.210.146.43])
	by hub.freebsd.org (Postfix) with ESMTP
	id 4AE3F37B72A; Wed, 26 Apr 2000 12:49:53 -0700 (PDT)
	(envelope-from csg@dustdevil.waterspout.com)
Received: (from csg@localhost)
	by dustdevil.waterspout.com (8.9.3/8.9.3) id OAA01501;
	Wed, 26 Apr 2000 14:58:26 -0500 (EST)
	(envelope-from csg)
Date: Wed, 26 Apr 2000 14:58:26 -0500
From: "C. Stephen Gunn" <csg@waterspout.com>
To: Archie Cobbs <archie@whistle.com>
Cc: Julian Elischer <julian@elischer.org>,
	"Louis A. Mamakos" <louie@TransSys.COM>, luigi@FreeBSD.ORG,
	remy@boostworks.com, pavel@alum.mit.edu, nsayer@sftw.com,
	freebsd-net@FreeBSD.ORG
Subject: Re: Proposal for ethernet, bridging, netgraph
Message-ID: <20000426145826.A1209@waterspout.com>
References: <390690B8.4487EB71@elischer.org> <200004261619.JAA58836@bubba.whistle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 1.0.1i
In-Reply-To: <200004261619.JAA58836@bubba.whistle.com>; from archie@whistle.com on Wed, Apr 26, 2000 at 09:19:52AM -0700
Sender: owner-freebsd-net@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

On Wed, Apr 26, 2000 at 09:19:52AM -0700, Archie Cobbs wrote:

> OK, new version of the patch..
> 
>   ftp://ftp.whistle.com/pub/archie/misc/net.cleanup.patch.3

I've got some "operational" questions on the new ether_input().
I promise not to mention trimming or not trimming the header in
this message. (whoops!)

I think the Bridge/BPF code should happen after we check the
interface for IFF_UP, and before the NG_DIVERT action.

I question the validity of calling bdg_forward() on packets that
are received on an interface that isn't IFF_UP|IFF_RUNNING.  For
instance, when I "ifconfig <int> down", I expect the interface to
not show me any traffic whatsoever.

I also think that the IFF_UP check should be modified to also check
IFF_RUNNING like this:

	/* Discard packet if interface is not up */
	if (ifp->if_flags & (IFF_UP|IFF_RUNNING) != (IFF_UP|IFF_RUNNING)) {
	        m_freem(m);
		return;
	}

I don't have a good feel on the interface statistics.  Personally
I expect to see the counters get incremented for _any_ packet
received on an interface.

 - Steve



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message