From owner-svn-ports-all@freebsd.org Wed Feb 20 18:55:29 2019 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 876EF14FCB95 for ; Wed, 20 Feb 2019 18:55:29 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2B4A98E5F9 for ; Wed, 20 Feb 2019 18:55:29 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) (Authenticated sender: sunpoet) by smtp.freebsd.org (Postfix) with ESMTPSA id E0EBA2FDF for ; Wed, 20 Feb 2019 18:55:28 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: by mail-ed1-f54.google.com with SMTP id j89so11424705edb.9 for ; Wed, 20 Feb 2019 10:55:28 -0800 (PST) X-Gm-Message-State: AHQUAuZPrCLDGU6RdhtvrL9rNu9AKs2Nbv3qShUEOCvJSiRMQiFCv2vW bcAyETuF37uLsu3azDyuXC6+QKxMTHavk5fRO2KKbg== X-Google-Smtp-Source: AHgI3IZDHI/8drpsg3sfAs+qwmG4CQb6tRqsXpxcQVEiIsJVAiDDUEXprS0KzAPwjMCOPcEKN+p4kNQoWrHmqFY47Fk= X-Received: by 2002:a17:906:35d8:: with SMTP id p24mr3193495ejb.112.1550688927819; Wed, 20 Feb 2019 10:55:27 -0800 (PST) MIME-Version: 1.0 References: <201902171938.x1HJcYFW032954@repo.freebsd.org> <20190218084610.GA11390@FreeBSD.org> <20190219073010.GA47552@FreeBSD.org> In-Reply-To: <20190219073010.GA47552@FreeBSD.org> From: Po-Chuan Hsieh Date: Thu, 21 Feb 2019 02:54:50 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r493186 - in head/net: . p5-Net-Ping To: Alexey Dokuchaev Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org X-Rspamd-Queue-Id: 2B4A98E5F9 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.99 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.99)[-0.986,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Feb 2019 18:55:29 -0000 On Tue, Feb 19, 2019 at 3:30 PM Alexey Dokuchaev wrote: > On Tue, Feb 19, 2019 at 07:54:53AM +0800, Po-Chuan Hsieh wrote: > > On Mon, Feb 18, 2019 at 4:46 PM Alexey Dokuchaev > wrote: > > > On Sun, Feb 17, 2019 at 07:38:34PM +0000, Sunpoet Po-Chuan Hsieh wrote: > > > > New Revision: 493186 > > > > URL: https://svnweb.freebsd.org/changeset/ports/493186 > > > > > > > > Log: > > > > Add p5-Net-Ping 2.71 > > > > > > Per MOVED, it was removed in 2016 because it's included in all > supported > > > versions of Perl, so what had happened since then? It was not > mentioned > > > in the commit log. > > > > Like Kurt said, it's the newer version in CPAN. I think it's the same > > reason why it's removed and now it's back. > > OK, so the plan is to remove it from Perl, or what? Otherwise, I don't see > why this situation won't repeat itself. >From my point of view, keeping a Perl core module as a port depends on several factors: - the version in CPAN - the version in supported Perl releases - the version other ports depend on (if the version from lang/perl5.xx is sufficient or not) Therefore, 1. We may need a port if CPAN is newer than all or some supported Perl releases. 2. A ports (from CPAN) can be removed if it is equivalent to or older than that in all supported Perl releases. 3. The port may come back if the situation changes, e.g. Net::Ping in this case. > > In fact, I made it from scratch and at the last step, instead of "svn > add", > > I checked MOVED, svn copied the old one and replaced the whole directory > > with mine. I didn't really read the diff. I could change it if you want. > > I don't insist, given your explanation. It would be better if this would > be made part of the commit log though. Thanks for replying, > > ./danfe >