From owner-svn-ports-all@freebsd.org Thu Dec 7 13:13:11 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 278B8E864C3; Thu, 7 Dec 2017 13:13:11 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (prod2.absolight.net [79.143.243.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "plouf.absolight.net", Issuer "CAcert Class 3 Root" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id DDC1763DE7; Thu, 7 Dec 2017 13:13:10 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id 80CA9BDD2F; Thu, 7 Dec 2017 14:13:08 +0100 (CET) Received: from atuin.in.mat.cc (AMontsouris-654-1-244-118.w90-44.abo.wanadoo.fr [90.44.187.118]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by prod2.absolight.net (Postfix) with ESMTPSA id 4506CBDD25; Thu, 7 Dec 2017 14:13:08 +0100 (CET) Subject: Re: svn commit: r455210 - in head: . Mk/Uses accessibility accessibility/accerciser accessibility/caribou accessibility/orca accessibility/py-atspi accessibility/py-speech-dispatcher accessibility/py3-... To: Jan Beich , Mathieu Arnold Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201711301550.vAUFoYsm001135@repo.freebsd.org> <2776e2b9-6614-6331-b7f7-4152c2e635c6@FreeBSD.org> <374m-4tz6-wny@FreeBSD.org> From: Mathieu Arnold Organization: Absolight / The FreeBSD Foundation Message-ID: <9435537e-2f1c-2daa-b579-6c7ac253e6d9@FreeBSD.org> Date: Thu, 7 Dec 2017 14:13:21 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <374m-4tz6-wny@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Dec 2017 13:13:11 -0000 Le 07/12/2017 =C3=A0 13:12, Jan Beich a =C3=A9crit=C2=A0: > Mathieu Arnold writes: > >> Le 07/12/2017 =C3=A0 00:16, Jan Beich a =C3=A9crit=C2=A0: >> >>> Mathieu Arnold writes: >>> >>>> Author: mat >>>> Date: Thu Nov 30 15:50:30 2017 >>>> New Revision: 455210 >>>> URL: https://svnweb.freebsd.org/changeset/ports/455210 >>>> >>>> Log: >>>> Convert Python ports to FLAVORS. >>> [...] >>>> Index: Mk/Uses/python.mk >>> [...] >>>> +.if ${FLAVOR:Mpy[23]*} >>> Shouldn't this use :U like suggested by CHANGES? >> I have absolutely no idea what you are replying to. > Maybe the following would help: > > $ svn blame Mk/Uses/python.mk | sed -n '/:Mpy/,/endif/p' > 455210 mat .if ${FLAVOR:Mpy[23]*} > 455210 mat _PYTHON_VERSION=3D ${FLAVOR:S/py//:C/(.)/\1./} > 455210 mat .endif FLAVOR is only undefined before all includes, it is defined very early in Mk/bsd.port.mk, so there is no need for :U in any Mk/* files. > $ sed -i '' 's/:Mpy/:U&/' Mk/Uses/python.mk > > $ svn diff Mk/Uses/python.mk > Index: Mk/Uses/python.mk > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- Mk/Uses/python.mk (revision 455493) > +++ Mk/Uses/python.mk (working copy) > @@ -436,7 +436,7 @@ FLAVOR=3D ${FLAVORS:[1]} > . endif > .endif > =20 > -.if ${FLAVOR:Mpy[23]*} > +.if ${FLAVOR:U:Mpy[23]*} > _PYTHON_VERSION=3D ${FLAVOR:S/py//:C/(.)/\1./} > .endif > =20 > --=20 Mathieu Arnold