From owner-freebsd-sparc64@FreeBSD.ORG Sat Sep 14 14:06:52 2013 Return-Path: Delivered-To: freebsd-sparc64@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 422EBD6D; Sat, 14 Sep 2013 14:06:52 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from smtpauth3.wiscmail.wisc.edu (wmauth3.doit.wisc.edu [144.92.197.226]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 185F2291E; Sat, 14 Sep 2013 14:06:51 +0000 (UTC) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII; format=flowed Received: from avs-daemon.smtpauth3.wiscmail.wisc.edu by smtpauth3.wiscmail.wisc.edu (Oracle Communications Messaging Server 7u4-27.01(7.0.4.27.0) 64bit (built Aug 30 2012)) id <0MT400J00CEVCB00@smtpauth3.wiscmail.wisc.edu>; Sat, 14 Sep 2013 09:06:43 -0500 (CDT) X-Spam-PmxInfo: Server=avs-3, Version=6.0.3.2322014, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.9.14.135714, SenderIP=0.0.0.0 X-Spam-Report: AuthenticatedSender=yes, SenderIP=0.0.0.0 Received: from comporellon.tachypleus.net (unknown [76.210.60.217]) by smtpauth3.wiscmail.wisc.edu (Oracle Communications Messaging Server 7u4-27.01(7.0.4.27.0) 64bit (built Aug 30 2012)) with ESMTPSA id <0MT40038DCJ5JS20@smtpauth3.wiscmail.wisc.edu>; Sat, 14 Sep 2013 09:06:43 -0500 (CDT) Message-id: <52346D71.4080407@freebsd.org> Date: Sat, 14 Sep 2013 09:06:41 -0500 From: Nathan Whitehorn User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130907 Thunderbird/17.0.8 To: Marius Strobl Subject: Re: Patch for Cross-Reference Phandles References: <522CC7E0.9060508@freebsd.org> <5231D8A6.9080501@freebsd.org> <20130914133155.GA32845@alchemy.franken.de> In-reply-to: <20130914133155.GA32845@alchemy.franken.de> Cc: freebsd-arm@freebsd.org, freebsd-sparc64 , freebsd-ppc@freebsd.org X-BeenThere: freebsd-sparc64@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to the Sparc List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Sep 2013 14:06:52 -0000 On 09/14/13 08:31, Marius Strobl wrote: > On Thu, Sep 12, 2013 at 10:07:18AM -0500, Nathan Whitehorn wrote: >> On 09/08/13 13:54, Nathan Whitehorn wrote: >>> Open Firmware has three namespaces for handles: >>> 1. Instance handles, for open devices >>> 2. Package handles for the client interface >>> 3. Package handles for device tree cross references >>> >>> On Powermac hardware, we assume that (2) and (3) are identical and >>> call both phandles. On embedded FDT systems, you can't open devices >>> and so we abuse ihandle_t for (3). IBM pSeries hardware, however, has >>> all three things. With that in mind, I'd like to start separating >>> them. The patch at >>> http://people.freebsd.org/~nwhitehorn/xref_phandle.diff adds a new >>> function (OF_child_xref_phandle) that takes a phandle of type (3) and >>> turns into one of type (2) by searching for entries named "phandle", >>> "ibm,phandle", or "linux,phandle" in the tree. This should work for >>> FDT as well, but is not connected in the patch to anything actually >>> FDT related. >>> >>> Comments would be appreciated. I'd like to get to get this as in as >>> soon as possible (given the HEAD freeze) otherwise. >>> -Nathan >> Since I haven't heard anything, it shouldn't affect any existing >> platforms or code, and it would be nice to have this interface available >> in the 10.x series, I plan to ask re@ for commit approval tomorrow. >> Please let me know if there are any objections. > Technically that patch is fine. It would be nice if you could fix the > style bugs before committing, though. In OF_child_xref_phandle(), the > variables should go above the comment and you don't need to initialize > the static global one in ofw_pcibus.c to zero explicitly. If you do > nevertheless, spaces should go before and after the '='. > Thanks! I think the explicit zero initialization adds some clarity for people reading the code, so I'd like to keep it. The rest of the changes have been made. -Nathan