From owner-freebsd-net@FreeBSD.ORG Wed Apr 15 20:34:11 2009 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B626C1065670 for ; Wed, 15 Apr 2009 20:34:11 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.227]) by mx1.freebsd.org (Postfix) with ESMTP id 87EC68FC1C for ; Wed, 15 Apr 2009 20:34:11 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: by rv-out-0506.google.com with SMTP id l9so73231rvb.43 for ; Wed, 15 Apr 2009 13:34:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=iX0nyAAJFYhyS3AlYTmoYwM3yln0inRPBcgeYFLclig=; b=xeeKTq1/ZtR9gcp1Pl1zjF30U3lrLJVQW/+NJPtUqHrq2xK8bUjX3sdGt9t/K4Ff4n MlwpeKIB+6YKw4t3eX0Q8ObY+b6zphAie2ArKXGgJuDWTu8c0oZOJF5YE0wtsZ0Dom/C GPqkBzslFA5m+bMCzlx7WE5s87/WfrUHSVamQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=QLr5teHCGbQMCNLiBmJz7co50wRwHoekM4qaypm163Zrh267MT9wQgXoJAZuxfqtbP XGTYs8ZwNELdrHRZSiXQQ4D1dJtluo1TDmsvAaLREnT92HBP2Y7/5FjURUj8uP6DFi0+ wxwNpUEcbQZZXY7SDp7CvLtlwgDQxt1w5b4Eo= MIME-Version: 1.0 Received: by 10.114.183.20 with SMTP id g20mr255738waf.142.1239825897570; Wed, 15 Apr 2009 13:04:57 -0700 (PDT) In-Reply-To: <3c1674c90904151106j543d4772s25786f81d7ff55a1@mail.gmail.com> References: <20090415084031.6d149fef@renaud-dev1> <3c1674c90904151106j543d4772s25786f81d7ff55a1@mail.gmail.com> Date: Wed, 15 Apr 2009 13:04:57 -0700 Message-ID: <2a41acea0904151304t69ff9f61q3053b2a011402626@mail.gmail.com> From: Jack Vogel To: Kip Macy Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Renaud Lienhart , freebsd-net@freebsd.org Subject: Re: tcp_output() might generate invalid TSO frames X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Apr 2009 20:34:12 -0000 No, the problem Mike is having is due to an issue in our new shared code in how we get the mac address, we changed it to support alt mac addresses, and it works find on our hardware, there is an issue in the vmware emulation. Nevertheless, if there's a problem in the TSO code it would be nice to get that fixed. Jack On Wed, Apr 15, 2009 at 11:06 AM, Kip Macy wrote: > Interesting. That might explain a problem that Mike Silbersack is > seeing with the latest em driver on vmware. > > I don't know of any NICs that actually choke on such frames. > Nonetheless, it is silly behavior. I'll try to see if we can get this > fixed before 7.2. > > Thanks, > Kip > > On Wed, Apr 15, 2009 at 8:40 AM, Renaud Lienhart > wrote: > > Hi, > > > > We're having trouble virtualizing FreeBSD 7+ on ESX because of an issue > > with the stack's TSO implementation: it sometimes generates TSO packets > > whose payload size is actually smaller than the MSS. > > > > The faulty logic is described, along with a patch, in PR #132832. It > > has been opened for a while now, without any apparent activity, which > > is why I'm reaching the mailing list directly. > > > > ESX currently drops these packets as many physical nics are known to > > choke on such frames, which effectively limits FreeBSD guests' > > performance. > > I don't know about other virtualization stacks' behavior. > > > > http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/132832 > > > > Thanks for your time, > > > > Renaud > > _______________________________________________ > > freebsd-net@freebsd.org mailing list > > http://lists.freebsd.org/mailman/listinfo/freebsd-net > > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" > > > > > > -- > All that is necessary for the triumph of evil is that good men do nothing. > Edmund Burke > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" >