From nobody Thu Apr 16 15:12:16 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fxM1s2ntzz6ZptB for ; Thu, 16 Apr 2026 15:12:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fxM1r4wb7z4Mvg for ; Thu, 16 Apr 2026 15:12:16 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776352336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0Jr5SfG2SrWFH46MKm9NfKbTe+KRsO/s3ZDuTWNJcLY=; b=tJ5JC4i6MEiLiKEigzfS1jdqIex7HJ3o/ZanyEE4TT7qk7CSqFcMIr/wyuLT9zCbuFA05i R8eWJj+TbrgpFq04BMG8aYzMfvjvwqkbPv1d9z81bajBqMM1608plsr6ZFirN9IWE/96qu kEPzkQnZOuqCb3acsqpaUm4Mb4MN8nbXJ+8r/o5WcdmNCohj4mESdecTTDaIzIr7GkexQR P4CSP4X23Ft6Ym6a8rdVZHtgIsvnk+WpTSrP/B1FFSsMzYX5llciL7rWC3ukFAWCiMiLiX QeHw00zFGk42cIpyR10/fozN4xvYHE2lagdwKs8NjxMhrmwyJ5iJyDe6ciYuDw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776352336; a=rsa-sha256; cv=none; b=Ocd9/MMjtvmsKCC3lESnKIvv3ycr9jutq82lan6YV39DRXCgFwnk2t5M5Gq//DDnJPONCz jkFXWURg0qwJN8ntVslG8D1X8mRBq4iZdlQYfHD3bXLNTxMTNvEiDjObJDKZOruoYNeo75 8uey7J3YDgoO8IHZb8zjydBjEJv49+ToFSBvYyqNYGzJNyvfTI++rAsxvDMg2qnNGL5tUQ LLY6eJlkpfzynfdGfOnl/eWJfu1EkQ++xULWvZQo16oecnglTEVW2k/HXyzwoWq1NZw4nj qjS3pKY4vPSlej4n8VbpOjTZpd+LXg8hTkr2NgdJSCvKa84CguanYlM5eUEHZQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776352336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0Jr5SfG2SrWFH46MKm9NfKbTe+KRsO/s3ZDuTWNJcLY=; b=U6FlA1koqOxiX3QgV7qxm3ASEoIg+Yt/zuYHYqZdCLKPYafTVyPiDlYmcwxR3n1zXOhSvS eVANLpUMVsoxTOQ6a0vAThD1NuRXQ1E/X8cfh6yspMrvwjRQfYd8AYYEwTsEW0pQHsofKh b7kx7AxvVhnR70DIBnLtEscuspQ7kT2dR9v5HhutL6ASvlu1wOmNfx/4gR/tBGBcwK+Mtz PXEzaK3ZOlSk2eJYkF596PQd71H/flqHDGvVC5YKENP76U1/xwHZ5l1fKSjHideullsYO8 vQRcxZ3sJ/p7Fmc8ad20coihoITGcT2XtnyTADyccSF8ltj9DJpyDMRvX2MEyg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fxM1r4TfMz1BTQ for ; Thu, 16 Apr 2026 15:12:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1eeb8 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 16 Apr 2026 15:12:16 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Colin Percival Subject: git: a25f78eafe47 - stable/14 - clapic_handle_intr: KASSERT isrc != NULL List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cperciva X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: a25f78eafe472cb161d1405f63ad8c4491416a6b Auto-Submitted: auto-generated Date: Thu, 16 Apr 2026 15:12:16 +0000 Message-Id: <69e0fc50.1eeb8.36b2d901@gitrepo.freebsd.org> The branch stable/14 has been updated by cperciva: URL: https://cgit.FreeBSD.org/src/commit/?id=a25f78eafe472cb161d1405f63ad8c4491416a6b commit a25f78eafe472cb161d1405f63ad8c4491416a6b Author: Colin Percival AuthorDate: 2026-03-14 01:03:44 +0000 Commit: Colin Percival CommitDate: 2026-04-16 15:11:54 +0000 clapic_handle_intr: KASSERT isrc != NULL If an interrupt arrives at a CPU which isn't expecting that particular vector, intr_lookup_source will return an isrc of NULL and we'll panic when intr_execute_handlers increments *isrc->is_count. Place a KASSERT a few nanoseconds earlier in order to leave some more breadcrumbs for the next person to trip over this behaviour. Tested on: EC2 r8i.96xlarge MFC after: 3 weeks Sponsored by: Amazon Differential Revision: https://reviews.freebsd.org/D55851 (cherry picked from commit f350063a251c9da0c5ce437eb4c44a2d716b673e) --- sys/x86/x86/local_apic.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sys/x86/x86/local_apic.c b/sys/x86/x86/local_apic.c index bf05855439bc..2efa0b9b5c1d 100644 --- a/sys/x86/x86/local_apic.c +++ b/sys/x86/x86/local_apic.c @@ -1287,6 +1287,9 @@ lapic_handle_intr(int vector, struct trapframe *frame) isrc = intr_lookup_source(apic_idt_to_irq(PCPU_GET(apic_id), vector)); + KASSERT(isrc != NULL, + ("lapic_handle_intr: vector %d unrecognized at lapic %u", + vector, PCPU_GET(apic_id))); intr_execute_handlers(isrc, frame); }