From owner-svn-src-all@FreeBSD.ORG Fri Aug 30 14:53:04 2013 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 28BF9545; Fri, 30 Aug 2013 14:53:04 +0000 (UTC) (envelope-from ian@FreeBSD.org) Received: from mho-01-ewr.mailhop.org (mho-03-ewr.mailhop.org [204.13.248.66]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id E9B462AE8; Fri, 30 Aug 2013 14:53:03 +0000 (UTC) Received: from c-24-8-230-52.hsd1.co.comcast.net ([24.8.230.52] helo=damnhippie.dyndns.org) by mho-01-ewr.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.72) (envelope-from ) id 1VFQ4H-000Nag-9g; Fri, 30 Aug 2013 14:52:57 +0000 Received: from [172.22.42.240] (revolution.hippie.lan [172.22.42.240]) by damnhippie.dyndns.org (8.14.3/8.14.3) with ESMTP id r7UEqss9057144; Fri, 30 Aug 2013 08:52:54 -0600 (MDT) (envelope-from ian@FreeBSD.org) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 24.8.230.52 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX19D4VCvE3UbeaTp1OiPNNWJ Subject: Re: svn commit: r255067 - head/sys/kern From: Ian Lepore To: Andriy Gapon In-Reply-To: <5220A458.3060202@FreeBSD.org> References: <201308301039.r7UAduI1052038@svn.freebsd.org> <5220A027.8070604@FreeBSD.org> <5220A2DD.5040803@bitfrost.no> <5220A458.3060202@FreeBSD.org> Content-Type: text/plain; charset="us-ascii" Date: Fri, 30 Aug 2013 08:52:54 -0600 Message-ID: <1377874374.1111.328.camel@revolution.hippie.lan> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit Cc: Hans Petter Selasky , svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Aug 2013 14:53:04 -0000 On Fri, 2013-08-30 at 16:55 +0300, Andriy Gapon wrote: > on 30/08/2013 16:49 Hans Petter Selasky said the following: > > On 08/30/13 15:37, Andriy Gapon wrote: > >> on 30/08/2013 13:39 Hans Petter Selasky said the following: > >>> Author: hselasky > >>> Date: Fri Aug 30 10:39:56 2013 > >>> New Revision: 255067 > >>> URL: http://svnweb.freebsd.org/changeset/base/255067 > >>> > >>> Log: > >>> Simplify pause_sbt() logic. Don't call DELAY() if remainder is less > >>> than or equal to zero. > >> > >> Discussed with? > >> Reviewed by? > >> Tested by? > >> > > > > Hi, > > > > I've checked MAINTAINERS first. > > > > A patch was sent to the freebsd-current mailing list, See XHCI USB debugging > > thread. > > I noticed that you committed the patch just a few minutes after making it > public. And later noticed that the patch did not result in any improvement. > > > Could probably have been discussed a bit more. > > Indeed. > > > The cold case logic for pause() > > is mainly used by the USB code and was factored out from usb_pause_mtx() a long > > while ago by me. > > Oh, I see. > > > Do you see anything technically wrong about my patch? > > I don't feel qualified enough. > What I want to know is why a DELAY() loop needs to function well with delay values longer than 1 second. Are we really doing that? -- Ian