From nobody Thu Dec 11 20:44:27 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dS4MH61wHz6KLFT for ; Thu, 11 Dec 2025 20:44:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dS4MH2TyBz3cDj for ; Thu, 11 Dec 2025 20:44:27 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1765485867; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=m5t7NTeVf+rRvpStZedxbZO2nqD5aK/qUazCApmB30g=; b=b9HDOUstEUvRt3/kHoLjtnS4i7yPxgqxFDwCPYsVI4oCxzbjsFdgFiYdWLW4BIl+CpxtPq KH/X+6WZc+AFExNPqWNLSH+ZU08ciEQvLNPs+oL0KaxW2bDO4ClBSKnejddqah2Sjve5c/ ru2xAB56mKBEeKDvYzADhUnE1cuMMc+EuE3q7SwT5wS2YZfY04/ND5FEvvM7zIR5oEm9DE 9aJilZ7Wlh4IzDPk0sOVnKZWGu0rwg2bIUDuEx6zXVpjnVqEAvpmW00PRbLhTS0hkp4yZb mLex72xMpq/mC2R01fsjMkxZcVMMuCoyJw5yCqwictNYhDVxMhb1Wvt5bp6uEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1765485867; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=m5t7NTeVf+rRvpStZedxbZO2nqD5aK/qUazCApmB30g=; b=Q1Qnhucn8hWUUQY+tw+jk1NRbFUKwpa+8V/82hbrjdX8BMMY5G6wAsbXZyO9uoI5xo+vLd +Tkuj9YvEMKRQL/+J93auTwJuzchvtLcKFoA8R8cXcnlena545CopD5+wcDbDyfoL2mTML ot44cqUVosG7YXGeYM3ZzJQzZ8p0V/1h8xt86Ib8yFdi2PZFiYGh9X/jIswWN8AsgaTrvH z14Ti7bO8r8r3rY5zhwvK3B5GfiWmxZTD9WGi3cd2QtJ3cWMREl0QP4DCmNNQqt/8ET6W+ n+08SFb8HVAVl+AS2s1V1FUbGcJMsXkJ3+3ezSG7TpAJjODuv/upnnNdz5dL0Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1765485867; a=rsa-sha256; cv=none; b=s+C8dGOty/w04f2Ayqzafics4pUHbRPaG71He+3QsgMArfsipHe15aMSEuq76b5Azfo2X+ I1pCyk9G1uerXeWyXOxTmUFUpy2IpT8y6ITu7Myzq6yqkSv5FMP9iIfdbRSVbcNek7ky+W R3dN1hBQAyNkY2scHfRZoWMILYYbC23W8JA0N2kkpAw/1d8FwjCnAJTLNF68Dr3WHEfKk5 fmi05HquQxlMfF6d/JdMib4r0jj2q8o+gfpR1PXYQAaF9iLg6pXlBS+KqX+7b3hJHuetbM Xp5Qj5gqULueZLlTfYPzboZtQq8P2n0hBFDgHqFL/fwxaEREjh6zVPc42UcEuw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dS4MH23kBzn0V for ; Thu, 11 Dec 2025 20:44:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 32245 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 11 Dec 2025 20:44:27 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: 618083e96701 - stable/14 - e1000: Bump 82574/82583 PBA to 32K List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 618083e96701c4c1ca197fa5d9a677471785515b Auto-Submitted: auto-generated Date: Thu, 11 Dec 2025 20:44:27 +0000 Message-Id: <693b2d2b.32245.8a9a250@gitrepo.freebsd.org> The branch stable/14 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=618083e96701c4c1ca197fa5d9a677471785515b commit 618083e96701c4c1ca197fa5d9a677471785515b Author: Kevin Bowling AuthorDate: 2025-11-21 05:02:00 +0000 Commit: Kevin Bowling CommitDate: 2025-12-11 20:44:00 +0000 e1000: Bump 82574/82583 PBA to 32K The reporter contacted me with packet loss and throughput fluctuations on a low power machine (Intel J1900) that got worse with the recent AIM algorithm in FreeBSD 14.2+. 32K RX PBA matches Linux default. Add a conditional path since we don't otherwise do a fixup for jumbo frames to retain space for two frames in Tx. With this change and an additional errata change, the throughput meets line rate for the reporter. Reported by: Codin Tested by: Codin (cherry picked from commit aa30bab9a92e1be230b9708bff9f33aae7d384e5) --- sys/dev/e1000/if_em.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sys/dev/e1000/if_em.c b/sys/dev/e1000/if_em.c index ce4269728903..0a25f4ec46b5 100644 --- a/sys/dev/e1000/if_em.c +++ b/sys/dev/e1000/if_em.c @@ -3105,9 +3105,13 @@ em_reset(if_ctx_t ctx) case e1000_82573: pba = E1000_PBA_12K; /* 12K for Rx, 20K for Tx */ break; + /* 82574/82583: Total Packet Buffer is 40K */ case e1000_82574: case e1000_82583: - pba = E1000_PBA_20K; /* 20K for Rx, 20K for Tx */ + if (hw->mac.max_frame_size > 8192) + pba = E1000_PBA_22K; /* 22K for Rx, 18K for Tx */ + else + pba = E1000_PBA_32K; /* 32K for RX, 8K for Tx */ break; case e1000_ich8lan: pba = E1000_PBA_8K;