From owner-p4-projects@FreeBSD.ORG  Wed Dec 17 08:46:17 2003
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 2067716A4D0; Wed, 17 Dec 2003 08:46:17 -0800 (PST)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id EF4A516A4CE
	for <perforce@freebsd.org>; Wed, 17 Dec 2003 08:46:16 -0800 (PST)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 27FD943D50
	for <perforce@freebsd.org>; Wed, 17 Dec 2003 08:46:16 -0800 (PST)
	(envelope-from jhb@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.10/8.12.10) with ESMTP id hBHGkG0B047815
	for <perforce@freebsd.org>; Wed, 17 Dec 2003 08:46:16 -0800 (PST)
	(envelope-from jhb@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.12.10/8.12.10/Submit) id hBHGkFus047812
	for perforce@freebsd.org; Wed, 17 Dec 2003 08:46:15 -0800 (PST)
	(envelope-from jhb@freebsd.org)
Date: Wed, 17 Dec 2003 08:46:15 -0800 (PST)
Message-Id: <200312171646.hBHGkFus047812@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	jhb@freebsd.org using -f
From: John Baldwin <jhb@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Subject: PERFORCE change 44025 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Dec 2003 16:46:17 -0000

http://perforce.freebsd.org/chv.cgi?CH=44025

Change 44025 by jhb@jhb_laptop on 2003/12/17 08:45:32

	A patch I've had on my laptop for ages to enable interrupt
	sources slightly earlier.

Affected files ...

.. //depot/projects/smpng/sys/kern/kern_intr.c#37 edit

Differences ...

==== //depot/projects/smpng/sys/kern/kern_intr.c#37 (text+ko) ====

@@ -546,22 +546,20 @@
 					mtx_unlock(&Giant);
 			}
 		}
+		WITNESS_WARN(WARN_PANIC, NULL, "suspending ithread");
+		mtx_assert(&Giant, MA_NOTOWNED);
 
+		if (ithd->it_enable != NULL)
+			ithd->it_enable(ithd->it_vector);
+
 		/*
 		 * Processed all our interrupts.  Now get the sched
 		 * lock.  This may take a while and it_need may get
 		 * set again, so we have to check it again.
 		 */
-		WITNESS_WARN(WARN_PANIC, NULL, "suspending ithread");
-		mtx_assert(&Giant, MA_NOTOWNED);
 		mtx_lock_spin(&sched_lock);
 		if (!ithd->it_need) {
-			/*
-			 * Should we call this earlier in the loop above?
-			 */
-			if (ithd->it_enable != NULL)
-				ithd->it_enable(ithd->it_vector);
-			TD_SET_IWAIT(td); /* we're idle */
+			TD_SET_IWAIT(td);
 			p->p_stats->p_ru.ru_nvcsw++;
 			CTR2(KTR_INTR, "%s: pid %d: done", __func__, p->p_pid);
 			mi_switch();