From owner-freebsd-hackers@FreeBSD.ORG Tue Mar 4 19:48:41 2008 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 516B6106566B; Tue, 4 Mar 2008 19:48:41 +0000 (UTC) (envelope-from keramida@ceid.upatras.gr) Received: from igloo.linux.gr (igloo.linux.gr [62.1.205.36]) by mx1.freebsd.org (Postfix) with ESMTP id A2DA78FC16; Tue, 4 Mar 2008 19:48:40 +0000 (UTC) (envelope-from keramida@ceid.upatras.gr) Received: from kobe.laptop (vader.bytemobile-rio.ondsl.gr [83.235.57.37]) (authenticated bits=128) by igloo.linux.gr (8.14.1/8.14.1/Debian-9) with ESMTP id m24JcVHO018585 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 4 Mar 2008 21:38:42 +0200 Received: from kobe.laptop (kobe.laptop [127.0.0.1]) by kobe.laptop (8.14.2/8.14.2) with ESMTP id m24JcPgL001972; Tue, 4 Mar 2008 21:38:25 +0200 (EET) (envelope-from keramida@ceid.upatras.gr) Received: (from keramida@localhost) by kobe.laptop (8.14.2/8.14.2/Submit) id m24JcPN0001971; Tue, 4 Mar 2008 21:38:25 +0200 (EET) (envelope-from keramida@ceid.upatras.gr) Date: Tue, 4 Mar 2008 21:38:25 +0200 From: Giorgos Keramidas To: obrien@freebsd.org, "M. Warner Losh" , hackers@freebsd.org Message-ID: <20080304193825.GA1947@kobe.laptop> References: <20080303.224256.635730757.imp@bsdimp.com> <20080304175810.GE90931@dragon.NUXI.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080304175810.GE90931@dragon.NUXI.org> X-Hellug-MailScanner: Found to be clean X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-3.976, required 5, autolearn=not spam, ALL_TRUSTED -1.80, AWL 0.42, BAYES_00 -2.60) X-Hellug-MailScanner-From: keramida@ceid.upatras.gr X-Spam-Status: No Cc: Subject: Re: Comments on pmake diffs for building on Linux X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Mar 2008 19:48:41 -0000 On 2008-03-04 09:58, David O'Brien wrote: >On Mon, Mar 03, 2008 at 10:42:56PM -0700, M. Warner Losh wrote: >> #include "arch.h" >> +#include "config.h" > > Are you able to use "CFLAGS+= -include config.h" instead? > If so, that would mean less .[ch] changes. Not with Sun Studio compilers on Solaris. There's a fair amount of things that can be done without _any_ source code change at all, but there's also a limit to what can be done. My $dayjob includes maintaining programs on Solaris, which built with Studio compilers, so I've already bumped against things like this :(