From owner-svn-src-all@FreeBSD.ORG Thu Mar 4 05:04:14 2010 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6E7A5106566C; Thu, 4 Mar 2010 05:04:14 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from sippysoft.com (gk1.360sip.com [72.236.70.240]) by mx1.freebsd.org (Postfix) with ESMTP id 309748FC12; Thu, 4 Mar 2010 05:04:13 +0000 (UTC) Received: from [192.168.1.38] (S0106005004e13421.vs.shawcable.net [70.71.175.212]) (authenticated bits=0) by sippysoft.com (8.14.3/8.14.3) with ESMTP id o2454Brm060681 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 3 Mar 2010 21:04:12 -0800 (PST) (envelope-from sobomax@FreeBSD.org) Message-ID: <4B8F3F4B.7020002@FreeBSD.org> Date: Wed, 03 Mar 2010 21:04:11 -0800 From: Maxim Sobolev Organization: Sippy Software, Inc. User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: Warner Losh References: <201003032153.o23LrQwl076528@svn.freebsd.org> In-Reply-To: <201003032153.o23LrQwl076528@svn.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn: head/sbin/newfs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Mar 2010 05:04:14 -0000 Warner Losh wrote: > Author: imp > Date: Wed Mar 3 21:53:25 2010 > New Revision: 204672 > URL: http://svn.freebsd.org/changeset/base/204672 > > Log: > Cast these to intmax_t before printing to fix build bustage. Better > solutions welcome. Thanks for a quick fix and sorry for the breakage. IMHO you fix's fine, there is no real reason to use 64-bit quantity anyway, it's just because expand_number(3) interface is not very well designed and forces anyone using it stick with that data type. So downsizing from 64-bit to 32-bit on platforms where intmax_t is 32-bit only (if any) should not be an issue in real life. -Maxim