Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 14 Sep 2012 17:16:52 +0300
From:      Aleksandr Rybalko <ray@freebsd.org>
To:        Grzegorz Bernacki <gber@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r240484 - head/sys/dev/fdt
Message-ID:  <20120914171652.780e25c6.ray@freebsd.org>
In-Reply-To: <201209140933.q8E9XZnd088621@svn.freebsd.org>
References:  <201209140933.q8E9XZnd088621@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 14 Sep 2012 09:33:35 +0000 (UTC)
Grzegorz Bernacki <gber@FreeBSD.org> wrote:

> Author: gber
> Date: Fri Sep 14 09:33:35 2012
> New Revision: 240484
> URL: http://svn.freebsd.org/changeset/base/240484
> 
> Log:
>   Set busaddr and bussize to 0 when fdt_get_range() fails.

Why bussize is 0?

>   
>   Obtained from:	Semihalf
> 
> Modified:
>   head/sys/dev/fdt/fdt_common.c
> 
> Modified: head/sys/dev/fdt/fdt_common.c
> ==============================================================================
> --- head/sys/dev/fdt/fdt_common.c	Fri Sep 14 08:11:59
> 2012	(r240483) +++ head/sys/dev/fdt/fdt_common.c	Fri
> Sep 14 09:33:35 2012	(r240484) @@ -431,7 +431,10 @@
> fdt_reg_to_rl(phandle_t node, struct res 
>  	if (fdt_addrsize_cells(OF_parent(node), &addr_cells,
> &size_cells) != 0) return (ENXIO);
> -	fdt_get_range(OF_parent(node), 0, &busaddr, &bussize);
> +	if (fdt_get_range(OF_parent(node), 0, &busaddr, &bussize)) {
> +		busaddr = 0;
> +		bussize = 0;
> +	}
>  
>  	tuple_size = sizeof(pcell_t) * (addr_cells + size_cells);
>  	tuples = OF_getprop_alloc(node, "reg", tuple_size, (void
> **)&reg);


-- 
Aleksandr Rybalko <ray@freebsd.org>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120914171652.780e25c6.ray>