From owner-freebsd-ports-bugs@FreeBSD.ORG Fri May 24 16:10:01 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 891879B0 for ; Fri, 24 May 2013 16:10:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 6AEE3BE1 for ; Fri, 24 May 2013 16:10:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r4OGA16M007341 for ; Fri, 24 May 2013 16:10:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r4OGA1GG007340; Fri, 24 May 2013 16:10:01 GMT (envelope-from gnats) Resent-Date: Fri, 24 May 2013 16:10:01 GMT Resent-Message-Id: <201305241610.r4OGA1GG007340@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Anton Yuzhaninov" Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 290AE7DF; Fri, 24 May 2013 16:08:57 +0000 (UTC) (envelope-from ayuzhaninov@openstat.ru) Received: from mail.openstat.ru (mail.openstat.ru [193.169.234.252]) by mx1.freebsd.org (Postfix) with ESMTP id D8A2AB91; Fri, 24 May 2013 16:08:56 +0000 (UTC) Received: from citrin.office.vega.ru ([10.100.124.49]) by mail.openstat.ru with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.80.1 (FreeBSD)) (envelope-from ) id 1UfuXw-0005sM-43; Fri, 24 May 2013 20:08:49 +0400 Received: by citrin.office.vega.ru (sSMTP sendmail emulation); Fri, 24 May 2013 20:08:47 +0400 Message-Id: Date: Fri, 24 May 2013 20:08:47 +0400 From: "Anton Yuzhaninov" To: FreeBSD-gnats-submit@freebsd.org X-Send-Pr-Version: 3.113 Subject: ports/178952: [PATCH] ports-mgmt/portlint: warn about ${SITE_PERL} in depends X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 May 2013 16:10:01 -0000 >Number: 178952 >Category: ports >Synopsis: [PATCH] ports-mgmt/portlint: warn about ${SITE_PERL} in depends >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Fri May 24 16:10:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Anton Yuzhaninov >Release: FreeBSD 10.0-CURRENT i386 >Organization: >Environment: System: FreeBSD citrin.office.vega.ru 10.0-CURRENT FreeBSD 10.0-CURRENT #2 r250144: Wed May 1 21:01:29 >Description: Warn about using ${SITE_PERL} in depends: 1. bsd.perl.mk should be included not for all ports. Conditional inclusion of bsd.perl.mk was reverted in http://svnweb.freebsd.org/changeset/ports/279560 because of widespread ${SITE_PERL} usage. 2. Such ports was fixed for most ports, see e. g.: http://svnweb.freebsd.org/changeset/ports/305672 but new ones appeared since... Generated with FreeBSD Port Tools 0.99_7 (mode: change, diff: ports) >How-To-Repeat: >Fix: --- portlint-2.14.3_1.patch begins here --- diff -ruN /usr/ports//ports-mgmt/portlint/Makefile ./Makefile --- /usr/ports//ports-mgmt/portlint/Makefile 2013-04-29 03:18:23.000000000 +0400 +++ ./Makefile 2013-05-24 19:43:05.000000000 +0400 @@ -6,6 +6,7 @@ PORTNAME= portlint PORTVERSION= 2.14.3 +PORTREVISION= 1 CATEGORIES= ports-mgmt MASTER_SITES= # none DISTFILES= # none diff -ruN /usr/ports//ports-mgmt/portlint/src/portlint.pl ./src/portlint.pl --- /usr/ports//ports-mgmt/portlint/src/portlint.pl 2013-04-29 03:18:23.000000000 +0400 +++ ./src/portlint.pl 2013-05-24 19:39:59.000000000 +0400 @@ -1134,6 +1134,14 @@ "USE_PERL5."); } + # Check for ${SITE_PERL} in depends + if ($m{'dep'} =~ m|^(\${SITE_PERL}/.*)$|) { + &perror("WARN", $file, -1, "dependency to $1 ". + "listed in $j. consider using p5-Example-Package-Name>=0. See ". + "http://www.freebsd.org/doc/en/books/porters-handbook/using-perl.html". + " for more details."); + } + # check USE_ICONV if ($m{'dep'} =~ /^(iconv\.\d+)$/) { &perror("WARN", $file, -1, "dependency to $1 ". --- portlint-2.14.3_1.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: