Date: Sat, 28 Apr 2018 22:20:49 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 210505] graphics/opencv: Update to 3.4.1 Message-ID: <bug-210505-7788-Lrheqwr72e@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-210505-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-210505-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D210505 --- Comment #76 from Jan Beich <jbeich@FreeBSD.org> --- (In reply to Steve Wills from comment #75) > +CMAKE_ON=3D ENABLE_CXX11 > +CMAKE_OFF=3D BUILD_ZLIB BUILD_TIFF BUILD_JASPER BUILD_JPEG BUILD_PNG BUI= LD_OPENEXR BUILD_TBB BUILD_IPP_IW BUILD_ITT BUILD_PROTOBUF To fit on ~80 column terminal maybe wrap long lines CMAKE_ON=3D ENABLE_CXX11 CMAKE_OFF=3D BUILD_ZLIB BUILD_TIFF ... \ BUILD_ITT BUILD_PROTOBUF or use +=3D but group e.g., CMAKE_OFF+=3D BUILD_ZLIB CMAKE_OFF+=3D BUILD_TIFF CMAKE_OFF+=3D BUILD_JASPER ... > +# Optional 3rd party components > +CMAKE_ARGS+=3D -DWITH_1394:BOOL=3DOFF \ > + -DWITH_CAROTENE:BOOL=3DOFF \ Sorry, I meant to convert all (unconditional) CMAKE_ARGS to CMAKE_ON/OFF. > -V4L_CMAKE_ON=3D -DCMAKE_REQUIRED_INCLUDES:STRING=3D"${LOCALBASE}/includ= e" > +V4L_CMAKE_ON=3D CMAKE_REQUIRED_INCLUDES:STRING=3D"${LOCALBASE}/include" A typo: missing -D. Simply drop the change to the line. > Are there more to do or is that all that's needed? That was readability cosmetics. Review is not blocking (no maintainer) and = can be done in parallel to exp-run. Or did you try to build all consumers local= ly? --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-210505-7788-Lrheqwr72e>