From owner-cvs-all@FreeBSD.ORG Thu Apr 1 02:58:28 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5584616A4CE; Thu, 1 Apr 2004 02:58:28 -0800 (PST) Received: from mx.nsu.ru (mx.nsu.ru [212.192.164.5]) by mx1.FreeBSD.org (Postfix) with ESMTP id D4EC043D31; Thu, 1 Apr 2004 02:58:27 -0800 (PST) (envelope-from danfe@regency.nsu.ru) Received: from regency.nsu.ru ([193.124.210.26]) by mx.nsu.ru with esmtp (Exim 4.30) id 1B8zuZ-0002Er-J5; Thu, 01 Apr 2004 17:59:03 +0700 Received: from regency.nsu.ru (localhost [127.0.0.1]) by regency.nsu.ru (8.12.10/8.12.10) with ESMTP id i31Awvxm075951; Thu, 1 Apr 2004 17:58:57 +0700 (NOVST) (envelope-from danfe@regency.nsu.ru) Received: (from danfe@localhost) by regency.nsu.ru (8.12.10/8.12.10/Submit) id i31AwvmZ075950; Thu, 1 Apr 2004 17:58:57 +0700 (NOVST) (envelope-from danfe) Date: Thu, 1 Apr 2004 17:58:57 +0700 From: Alexey Dokuchaev To: Ruslan Ermilov Message-ID: <20040401105857.GA72284@regency.nsu.ru> References: <20040331211028.37B5016A4E2@hub.freebsd.org> <20040331134609.N90425@root.org> <20040401064241.GA18644@ip.net.ua> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040401064241.GA18644@ip.net.ua> User-Agent: Mutt/1.4.1i cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org cc: Nate Lawson Subject: Re: cvs commit: src/sys/pci if_ste.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Apr 2004 10:58:28 -0000 On Thu, Apr 01, 2004 at 09:42:41AM +0300, Ruslan Ermilov wrote: > On Wed, Mar 31, 2004 at 01:47:16PM -0800, Nate Lawson wrote: > > On Wed, 31 Mar 2004, Ruslan Ermilov wrote: > > > Modified files: > > > sys/pci if_ste.c > > > Log: > > > Under a heavy RX load, at least with D-Link DFE-550TX adapters, > > > the driver's RX ring head may fall behind the chip, causing the > > > stuck traffic, disordered packets, etc. Work around this by > > > adopting the technique of resyncing RX head used in dc(4) and > > > xl(4) drivers, but do it in a slightly different place to reduce > > > the number of resyncs needed. > > > > > > Also, set the NIC's RX polling period to a more meaningful value, > > > to stop overloading the PCI bus (this also reduces the number of > > > resyncs by a factor of 3 or more in a long run; the actual number > > > is very dependent on a nature of the traffic). > > > > > > Maintain the statistics counter as the hw.ste_rxsyncs sysctl. > > > > This pollutes the toplevel hw sysctl space. Please move it to > > hw.ste.rxsyncs or better, debug.*. > > > Seems I followed the bad practice from dc(4) and fxp(4). I will > move it to hw.ste, thanks. Care to fix this "bad practice" in dc(4) and fxp(4) as well? :) Or should we wait for their maintainers, or possibly filling the PR ? ./danfe