Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 25 Feb 2015 16:29:31 +0100
From:      John Marino <freebsd.contact@marino.st>
To:        Mark Felder <feld@FreeBSD.org>, ports-committers@freebsd.org,  svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r379920 - in head/dns/ldns: . files
Message-ID:  <54EDEA5B.7090907@marino.st>
In-Reply-To: <54EDE96B.2080703@marino.st>
References:  <201502251444.t1PEig7Z044705@svn.freebsd.org> <54EDE96B.2080703@marino.st>

next in thread | previous in thread | raw e-mail | index | archive | help
On 2/25/2015 16:25, John Marino wrote:
> On 2/25/2015 15:44, Mark Felder wrote:
>> Author: feld
>> Date: Wed Feb 25 14:44:41 2015
>> New Revision: 379920
>> URL: https://svnweb.freebsd.org/changeset/ports/379920
>> QAT: https://qat.redports.org/buildarchive/r379920/
>>
>> Log:
>>   Fix issues with LibreSSL
>>   
>>   PR:		191853
>>   Approved by:	maintainer
>>
>> Added:
>>   head/dns/ldns/files/
>>   head/dns/ldns/files/patch-drill_Makefile.in   (contents, props changed)
>>   head/dns/ldns/files/patch-examples_Makefile.in   (contents, props changed)
>>   head/dns/ldns/files/patch-examples_configure.ac   (contents, props changed)
>>   head/dns/ldns/files/patch-examples_ldns-signzone.c   (contents, props changed)
>> Modified:
>>   head/dns/ldns/Makefile
>>
>> Modified: head/dns/ldns/Makefile
>> ==============================================================================
>> --- head/dns/ldns/Makefile	Wed Feb 25 14:35:07 2015	(r379919)
>> +++ head/dns/ldns/Makefile	Wed Feb 25 14:44:41 2015	(r379920)
>> @@ -3,7 +3,7 @@
>>  
>>  PORTNAME=	ldns
>>  PORTVERSION=	1.6.17
>> -PORTREVISION=	3
>> +PORTREVISION=	4
>>  CATEGORIES=	dns
>>  MASTER_SITES=	http://www.nlnetlabs.nl/downloads/ldns/ \
>>  		LOCAL/ehaupt
>> @@ -80,6 +80,7 @@ INSTALL_TARGET+=install-manpages
>>  .if ${PORT_OPTIONS:MGOST}
>>  . if ${OSVERSION} < 1000015
>>  BUILD_DEPENDS+=	openssl>=1.0:${PORTSDIR}/security/openssl
>> +CONFLICTS+=    libressl-*
>>  . endif
>>  .else
>>  NO_GOST=	--disable-gost
>>
>> Added: head/dns/ldns/files/patch-drill_Makefile.in
>> ==============================================================================
>> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
>> +++ head/dns/ldns/files/patch-drill_Makefile.in	Wed Feb 25 14:44:41 2015	(r379920)
>> @@ -0,0 +1,11 @@
>> +--- drill/Makefile.in.orig	2014-01-10 21:04:41 UTC
>> ++++ drill/Makefile.in
>> +@@ -98,7 +98,7 @@ doc:	
>> + 
>> + install: all
>> + 	$(INSTALL) -d $(DESTDIR)$(bindir)
>> +-	$(INSTALL) drill $(DESTDIR)$(bindir)/drill
>> ++	$(INSTALL) -s drill $(DESTDIR)$(bindir)/drill
>> + 	$(INSTALL) -m 644 drill.1 $(DESTDIR)$(mandir)/man1/drill.1
>> + 
>> + uninstall:
> 
> If you are patching this file anyway, should not use use
> BSD_INSTALL_MAN, BSD_INSTALL_SCRIPT, BSD_INSTALL_PROGRAM instead?
> 

To be clear, unconditionally stripping the program is not correct.
BSD_INSTALL_PROGRAM will work with "WITH_DEBUG=yes", this will not.

John




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?54EDEA5B.7090907>