From owner-dev-commits-src-main@freebsd.org Mon May 31 19:37:21 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 230BA64DFA8 for ; Mon, 31 May 2021 19:37:21 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Fv5Cj00nQz4lrr for ; Mon, 31 May 2021 19:37:20 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x72d.google.com with SMTP id h20so12108944qko.11 for ; Mon, 31 May 2021 12:37:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WsDzVjMaRg+rOFVMEtTwSgZvPWnjL9gbGN7d70U86Kg=; b=ShXSPBdCbwPAozxjGGhtQnoR1DguJ3dAM+e+b3n6q4/fBKhk7VtusPzqBW5JK7SvfN nnR4zseL7wCuWuU1z790+0F2LQSd/O+x1ION3JozTvMYizI04Fc+ASvWsTISiYeuEGQB NvUScs0lw309Gye18m03EiEtUcxxMPk9jSrDEFQ+rJ+gsI2A7exos5kme5i2YKTGlpyF HW3aHIQQRjZrc33BmJviVcKb3VqKiO6oZ7Krue9VLX6wpDB00kwjjqch/lk4Xfau/CdA ysn8T4EAv5ot1fkPFHu4FrW3SdC5O4416vvsfpPDngBMEHuWFZnZf2iMUD0vsSSsUZQC hvDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WsDzVjMaRg+rOFVMEtTwSgZvPWnjL9gbGN7d70U86Kg=; b=fItKrO76ywlY0gilfdn0ETPDLUFShrs9v0b6exzDw9BHhoJKC5ObweaTU481SvL8GJ OwsQSTX2W3xLDn8PNIuM3t1FZezd7wNpGeL7sWjEsOkXPNckG81493eZVcdyMh2Nkigg SVBzFFGtpUNx+XJu1+AhneR/iOUAw0S0SZdNc5wZrZExQSSPArtpJj/5SSV/n8l2s5Wy olZoos7LU3cBCQR0lD/lsADIQUqIqQw0Yy0SiUEEb4p10ZGsm/ia/l//MWnPMf+6eMwO qs2blagfYKZs7gtns8Vg7IAzyKjRBVHvC+syc5CbQorgh2Txw37iqssB6RGTm8L73frw tLgQ== X-Gm-Message-State: AOAM531W1o0EBTYxEwFuJoQ1edWOgKnhkwyVwtQ6CrUd79KqhWMwlihM 5O6W0sHWd9cZ2wFfaoKmiAICNTFi5f3R5VgSaWMyZQ== X-Google-Smtp-Source: ABdhPJyEmAglRJyWbmD9fyej2T5XKBMRuqoBhA59TW+vQ8RTbJv0wbQJv82l8X07GBya8SRoL/NuDq7dGPwBx+MB6oo= X-Received: by 2002:a05:620a:e09:: with SMTP id y9mr17856534qkm.359.1622489840077; Mon, 31 May 2021 12:37:20 -0700 (PDT) MIME-Version: 1.0 References: <202105302249.14UMnbcl094541@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Mon, 31 May 2021 13:37:09 -0600 Message-ID: Subject: Re: git: 5a20c351ea45 - main - [skip ci] add a CODEOWNERS file To: Jessica Clarke Cc: Ed Maste , Alan Somers , src-committers , "" , dev-commits-src-main@freebsd.org X-Rspamd-Queue-Id: 4Fv5Cj00nQz4lrr X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 May 2021 19:37:21 -0000 On Mon, May 31, 2021 at 1:21 PM Jessica Clarke wrote: > On 31 May 2021, at 20:16, Warner Losh wrote: > > > > > > > > On Mon, May 31, 2021, 1:11 PM Ed Maste wrote: > > On Mon, 31 May 2021 at 11:51, Alan Somers wrote: > > > > > >> > > >> I think this file isn't the right place for (another copy of) this > > >> text; perhaps the CODEOWNERS file should just reference the top-leve= l > > >> MAINTAINERS? > > > > > > Except that CODEOWNERS is in a format that tools know how to parse. > If anything, MAINTAINERS should be a symlink to CODEOWNERS. > > > > At least the file's location and user IDs suggest that it is specific > > to GitHub; in any case I don't really care which one points to which. > > I hope we can agree though that we don't really want two different > > files representing code ownership in different ways that both > > independently refer to a third mechanism for recording code ownership > > that's external to the source tree? > > > > It also works on gitlab, FWIW. The format is standard. Bummer we can't > generate it based on where it is published=E2=80=A6 > > We could conceivably have a CODEOWNERS.master from which the others can b= e > generated via `make codeowners` whenever someone edits it. Whether that= =E2=80=99s > worth the hassle of implementing though for a file that shouldn=E2=80=99t= regularly > be changing is unclear. > Doing that's trivial... However, it would mean that the automatic flagging that this file's presence gives wouldn't work... But then again, there's no issues or pull requests at the gitlab mirror, so at the moment it's a bit of a moot point. Warner