From owner-svn-src-all@FreeBSD.ORG Thu Oct 21 12:17:46 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C41BC106566B; Thu, 21 Oct 2010 12:17:46 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 925258FC13; Thu, 21 Oct 2010 12:17:46 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 3860746B0C; Thu, 21 Oct 2010 08:17:46 -0400 (EDT) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id EE0818A01D; Thu, 21 Oct 2010 08:17:44 -0400 (EDT) From: John Baldwin To: Xin LI Date: Thu, 21 Oct 2010 07:46:41 -0400 User-Agent: KMail/1.13.5 (FreeBSD/7.3-CBSD-20100819; KDE/4.4.5; amd64; ; ) References: <201010210857.o9L8vPVQ084307@svn.freebsd.org> In-Reply-To: <201010210857.o9L8vPVQ084307@svn.freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201010210746.41227.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Thu, 21 Oct 2010 08:17:45 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.96.3 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.9 required=4.2 tests=BAYES_00 autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on bigwig.baldwin.cx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r214125 - head/sys/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2010 12:17:46 -0000 On Thursday, October 21, 2010 4:57:25 am Xin LI wrote: > Author: delphij > Date: Thu Oct 21 08:57:25 2010 > New Revision: 214125 > URL: http://svn.freebsd.org/changeset/base/214125 > > Log: > In syscall_module_handler(): all switch branches return, remove > unreached code as pointed out in a Chinese forum [1]. > > [1] http://www.freebsdchina.org/forum/viewtopic.php?t=50619 > > Pointed out by: btw616 > MFC after: 1 month I think this exposes a bug though in that the default case doesn't pass through to chainevh. The default case should look more like the removed code (except returning EOPNOTSUPP instead of 0 if there is no chainevh). -- John Baldwin