From owner-freebsd-ports@FreeBSD.ORG  Mon May 16 19:43:59 2011
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0AD8F106564A;
	Mon, 16 May 2011 19:43:59 +0000 (UTC)
	(envelope-from ohauer@FreeBSD.org)
Received: from u18-124.dslaccess.de (unknown [194.231.39.124])
	by mx1.freebsd.org (Postfix) with ESMTP id ACEAE8FC14;
	Mon, 16 May 2011 19:43:58 +0000 (UTC)
Received: from [172.20.1.100] (cde1100.uni.vrs [172.20.1.100])
	(Authenticated sender: ohauer)
	by u18-124.dslaccess.de (Postfix) with ESMTPSA id CF9532026A;
	Mon, 16 May 2011 21:43:53 +0200 (CEST)
Message-ID: <4DD17E78.20003@FreeBSD.org>
Date: Mon, 16 May 2011 21:43:52 +0200
From: Olli Hauer <ohauer@FreeBSD.org>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
	rv:1.9.2.17) Gecko/20110414 Thunderbird/3.1.10
MIME-Version: 1.0
To: utisoft@gmail.com
References: <4DD09B45.9070306@FreeBSD.org>
	<alpine.BSF.2.00.1105152216460.20421@wonkity.com>
	<BANLkTin08WiMbkzpKmq_zaz2cGp0esMJxg@mail.gmail.com>
	<alpine.BSF.2.00.1105160754150.22315@wonkity.com>
	<BANLkTi=ZV75sVcW_wf9mvjad2EV6TVrZmg@mail.gmail.com>
In-Reply-To: <BANLkTi=ZV75sVcW_wf9mvjad2EV6TVrZmg@mail.gmail.com>
X-Enigmail-Version: 1.1.1
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: Warren Block <wblock@wonkity.com>, Doug Barton <dougb@freebsd.org>,
	FreeBSD Ports <freebsd-ports@freebsd.org>
Subject: Re: proper use of bsd.port.options.mk
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: ohauer@FreeBSD.org
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 16 May 2011 19:43:59 -0000

On 2011-05-16 21:11, Chris Rees wrote:
> On 16 May 2011 19:47, Warren Block <wblock@wonkity.com> wrote:
>>
>> Could you give an example?  I looked, but nothing obvious jumped out.
>>
> 
> I think you (and ohauer) missed my followup with an example [1].
> 
> Chris
> 
> [1] http://www.mail-archive.com/freebsd-ports@freebsd.org/msg33780.html
> 

Hm, at the moment I seen no benefit in your example, since it was
written this way before <bsd.port.options.mk>

 OPTIONS=    WITH_JAVA "With Java" on

-.include <bsd.port.options.mk>
+.include <bsd.port.pre.mk>

 .if !defined(WITHOUT_JAVA)
 USE_JAVA=1.5+
 .endif

-.include <bsd.port.pre.mk>

 --- do something with JAVA_PORT ----

 .include <bsd.port.post.mk>