From owner-svn-src-head@freebsd.org Tue Oct 16 05:39:45 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B747C10E24DE; Tue, 16 Oct 2018 05:39:45 +0000 (UTC) (envelope-from antoine.brodin.freebsd@gmail.com) Received: from mail-it1-f175.google.com (mail-it1-f175.google.com [209.85.166.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5A7787BE46; Tue, 16 Oct 2018 05:39:45 +0000 (UTC) (envelope-from antoine.brodin.freebsd@gmail.com) Received: by mail-it1-f175.google.com with SMTP id p64-v6so30756022itp.0; Mon, 15 Oct 2018 22:39:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=p1PHhgKni2d8CiurkQcGUC1AeSCnM4QC/G2lhwjKzGU=; b=bPLvi5pNM+Mhn9aqoIfQuti44EVlTyYq+Kop0kNcb5GzgIOklh4ZhaNkKfArd3h0lr xAjrnR6IZLpln4hcpqh2iimCEGGQgECgtKgBiWLl/TRZ+Fn0iRbt4imSR8T8MR8x0dQ7 d32UTLlSLg8i1yAzdGA5r/Jzj4l552po9MlRTrlJlDjSYalDnCheMtfPxPmMS+/4Vrd0 gkmktWlhW2MLOf768SkPap/EVGWJs/axeb1j2P5n7Jmug7B9Dc0vJFcP8M6GRcPa/HwT nwbdnNcdG4rXNp7dXFFLRg8nx6duf4S9qcH6r9/syEJ+R8ZFxmTab8fnFY1Fo1Xpjwo6 J1Wg== X-Gm-Message-State: ABuFfog6zA947AO/VAZHbKUFO8tAQ4sZOWD0cZTIkyH6MnGsQfU/712+ TF6vezLy/6bI+qM0sm8Z/j8WIr4RSTmO0Y07rVKhWw== X-Google-Smtp-Source: ACcGV63NMSh8Mqt9/c4TqtILhYlfUEZxxbCWZsNYQnZY0yZ4bvgMhqs8FSlQoPTn4P2hvfFB/8zx8yTHgKFrQW5NN9s= X-Received: by 2002:a24:fe86:: with SMTP id w128-v6mr11808716ith.84.1539668384097; Mon, 15 Oct 2018 22:39:44 -0700 (PDT) MIME-Version: 1.0 References: <201810132126.w9DLQ73C022496@repo.freebsd.org> In-Reply-To: From: Antoine Brodin Date: Tue, 16 Oct 2018 07:39:32 +0200 Message-ID: Subject: Re: svn commit: r339350 - head/contrib/elftoolchain/elfcopy To: Ed Maste Cc: Gerald Pfeifer , re , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: multipart/mixed; boundary="0000000000001b5a93057851fb83" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2018 05:39:46 -0000 --0000000000001b5a93057851fb83 Content-Type: text/plain; charset="UTF-8" On Mon, Oct 15, 2018 at 3:53 PM Ed Maste wrote: > On Mon, 15 Oct 2018 at 07:13, Ed Maste wrote: > > Hi Antoine, did you bisect to this rev or does it just look like the > > most probable candidate? Can you copy a pair of differing .o files > > (say, gcc/cc1plus-checksum.o) from the work dir to freefall? > > Antoine provided a tarball of the work dir to me, and pointed out that > the *-checksum.o files are not interesting - they are warnings only > and are present prior to the identified change. > > Comparing one of the other differing files, e.g. > stage{2,3}-gcc/expmed.o, demonstrates the problem. Gcc's build > machinery is reasonably obfuscated so I'm not sure of the exact set of > operations, but I can infer that the stage2/stage3 comparison is > running strip on the object files and then comparing the result. Gcc > is encountering this part of my strip/objcopy change: > > > Stripping binaries with relocations > > referencing removed symbols was already broken, and after this change > > may still be broken in a different way. > > Stripping symbols and relocations from an object file is not a > particularly useful operation, since the object then can't be linked > or otherwise used. But it seems Gcc's stage comparison relies on this. > I did try running "strip --strip-debug" on stage{2,3}-gcc/expmed.o (a > reasonable operation on object files) and that produced identical > output. > > It may well be that a further change to ELF Tool Chain's strip is > warranted, but I suspect the most straightforward and reliable fix > here will be to just have gcc use GNU strip. The attached patch for the gcc ports fixes the failures for me. Antoine --0000000000001b5a93057851fb83 Content-Type: text/x-patch; charset="US-ASCII"; name="gcc-strip.diff" Content-Disposition: attachment; filename="gcc-strip.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jnbarwaf0 SW5kZXg6IGxhbmcvZ2NjNDgvTWFrZWZpbGUKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gbGFuZy9nY2M0OC9NYWtl ZmlsZQkocmV2aXNpb24gNDgyMTY1KQorKysgbGFuZy9nY2M0OC9NYWtlZmlsZQkod29ya2luZyBj b3B5KQpAQCAtMzMsNiArMzMsNyBAQAogU1VGRklYPQkJJHtQT1JUVkVSU0lPTjpDLyhbMC05XSsp LihbMC05XSspLiovXDFcMi99CiBVU0VTPQkJY29tcGlsZXIgY3BlIGdtYWtlIGljb252IGxpYnRv b2wgbWFrZWluZm8gcGVybDUgdGFyOmJ6aXAyCiBVU0VfQklOVVRJTFM9CXllcworQklOQVJZX0FM SUFTPQlzdHJpcD0ke0xPQ0FMQkFTRX0vYmluL3N0cmlwCiBVU0VfUEVSTDU9CWJ1aWxkCiBTU1Bf VU5TQUZFPQl5ZXMKIApJbmRleDogbGFuZy9nY2M0OS9NYWtlZmlsZQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBs YW5nL2djYzQ5L01ha2VmaWxlCShyZXZpc2lvbiA0ODIxNjUpCisrKyBsYW5nL2djYzQ5L01ha2Vm aWxlCSh3b3JraW5nIGNvcHkpCkBAIC0zMyw2ICszMyw3IEBACiBTVUZGSVg9CQkke1BPUlRWRVJT SU9OOkMvKFswLTldKykuKFswLTldKykuKi9cMVwyL30KIFVTRVM9CQljb21waWxlciBjcGUgZ21h a2UgaWNvbnYgbGlidG9vbCBtYWtlaW5mbyBwZXJsNSB0YXI6YnppcDIKIFVTRV9CSU5VVElMUz0J eWVzCitCSU5BUllfQUxJQVM9CXN0cmlwPSR7TE9DQUxCQVNFfS9iaW4vc3RyaXAKIFVTRV9QRVJM NT0JYnVpbGQKIFNTUF9VTlNBRkU9CXllcwogCkluZGV4OiBsYW5nL2djYzUvTWFrZWZpbGUKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gbGFuZy9nY2M1L01ha2VmaWxlCShyZXZpc2lvbiA0ODIxNjUpCisrKyBsYW5n L2djYzUvTWFrZWZpbGUJKHdvcmtpbmcgY29weSkKQEAgLTM0LDYgKzM0LDcgQEAKIFNVRkZJWD0J CSR7UE9SVFZFUlNJT046Qy8oWzAtOV0rKS4qL1wxL30KIFVTRVM9CQljb21waWxlciBjcGUgZ21h a2UgaWNvbnYgbGlidG9vbCBtYWtlaW5mbyBwZXJsNSB0YXI6eHoKIFVTRV9CSU5VVElMUz0JeWVz CitCSU5BUllfQUxJQVM9CXN0cmlwPSR7TE9DQUxCQVNFfS9iaW4vc3RyaXAKIFVTRV9QRVJMNT0J YnVpbGQKIFNTUF9VTlNBRkU9CXllcwogCkluZGV4OiBsYW5nL2djYzYvTWFrZWZpbGUKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gbGFuZy9nY2M2L01ha2VmaWxlCShyZXZpc2lvbiA0ODIxNjUpCisrKyBsYW5nL2dj YzYvTWFrZWZpbGUJKHdvcmtpbmcgY29weSkKQEAgLTM1LDYgKzM1LDcgQEAKIFNVRkZJWD0JCSR7 UE9SVFZFUlNJT046Qy8oWzAtOV0rKS4qL1wxL30KIFVTRVM9CQljb21waWxlciBjcGUgZ21ha2Ug aWNvbnYgbGlidG9vbCBtYWtlaW5mbyBwZXJsNSB0YXI6eHoKIFVTRV9CSU5VVElMUz0JeWVzCitC SU5BUllfQUxJQVM9CXN0cmlwPSR7TE9DQUxCQVNFfS9iaW4vc3RyaXAKIFVTRV9QRVJMNT0JYnVp bGQKIFNTUF9VTlNBRkU9CXllcwogQ0ZMQUdTOj0JJHtDRkxBR1M6Ti1tcmV0cG9saW5lfQpJbmRl eDogbGFuZy9nY2M2LWRldmVsL01ha2VmaWxlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGxhbmcvZ2NjNi1kZXZl bC9NYWtlZmlsZQkocmV2aXNpb24gNDgyMTY1KQorKysgbGFuZy9nY2M2LWRldmVsL01ha2VmaWxl CSh3b3JraW5nIGNvcHkpCkBAIC00MCw2ICs0MCw3IEBACiBTVUZGSVg9CQkke1BPUlRWRVJTSU9O OkMvKFswLTldKykuKi9cMS99CiBVU0VTPQkJY29tcGlsZXIgY3BlIGdtYWtlIGljb252IGxpYnRv b2wgbWFrZWluZm8gcGVybDUgdGFyOnh6CiBVU0VfQklOVVRJTFM9CXllcworQklOQVJZX0FMSUFT PQlzdHJpcD0ke0xPQ0FMQkFTRX0vYmluL3N0cmlwCiBVU0VfUEVSTDU9CWJ1aWxkCiBTU1BfVU5T QUZFPQl5ZXMKIApJbmRleDogbGFuZy9nY2M3L01ha2VmaWxlCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGxhbmcv Z2NjNy9NYWtlZmlsZQkocmV2aXNpb24gNDgyMTY1KQorKysgbGFuZy9nY2M3L01ha2VmaWxlCSh3 b3JraW5nIGNvcHkpCkBAIC0zNCw2ICszNCw3IEBACiBTVUZGSVg9CQkke1BPUlRWRVJTSU9OOkMv KFswLTldKykuKi9cMS99CiBVU0VTPQkJY29tcGlsZXIgY3BlIGdtYWtlIGljb252IGxpYnRvb2wg bWFrZWluZm8gcGVybDUgdGFyOnh6CiBVU0VfQklOVVRJTFM9CXllcworQklOQVJZX0FMSUFTPQlz dHJpcD0ke0xPQ0FMQkFTRX0vYmluL3N0cmlwCiBVU0VfUEVSTDU9CWJ1aWxkCiBTU1BfVU5TQUZF PQl5ZXMKIENGTEFHUzo9CSR7Q0ZMQUdTOk4tbXJldHBvbGluZX0KSW5kZXg6IGxhbmcvZ2NjNy1k ZXZlbC9NYWtlZmlsZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBsYW5nL2djYzctZGV2ZWwvTWFrZWZpbGUJKHJl dmlzaW9uIDQ4MjE2NSkKKysrIGxhbmcvZ2NjNy1kZXZlbC9NYWtlZmlsZQkod29ya2luZyBjb3B5 KQpAQCAtNDAsNiArNDAsNyBAQAogU1VGRklYPQkJJHtQT1JUVkVSU0lPTjpDLyhbMC05XSspLiov XDEvfQogVVNFUz0JCWNvbXBpbGVyIGNwZSBnbWFrZSBpY29udiBsaWJ0b29sIG1ha2VpbmZvIHBl cmw1IHRhcjp4egogVVNFX0JJTlVUSUxTPQl5ZXMKK0JJTkFSWV9BTElBUz0Jc3RyaXA9JHtMT0NB TEJBU0V9L2Jpbi9zdHJpcAogVVNFX1BFUkw1PQlidWlsZAogU1NQX1VOU0FGRT0JeWVzCiAKSW5k ZXg6IGxhbmcvZ2NjOC9NYWtlZmlsZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBsYW5nL2djYzgvTWFrZWZpbGUJ KHJldmlzaW9uIDQ4MjE2NSkKKysrIGxhbmcvZ2NjOC9NYWtlZmlsZQkod29ya2luZyBjb3B5KQpA QCAtMzQsNiArMzQsNyBAQAogU1VGRklYPQkJJHtQT1JUVkVSU0lPTjpDLyhbMC05XSspLiovXDEv fQogVVNFUz0JCWNvbXBpbGVyIGNwZSBnbWFrZSBpY29udiBsaWJ0b29sIG1ha2VpbmZvIHBlcmw1 IHRhcjp4egogVVNFX0JJTlVUSUxTPQl5ZXMKK0JJTkFSWV9BTElBUz0Jc3RyaXA9JHtMT0NBTEJB U0V9L2Jpbi9zdHJpcAogVVNFX1BFUkw1PQlidWlsZAogU1NQX1VOU0FGRT0JeWVzCiBDRkxBR1M6 PQkke0NGTEFHUzpOLW1yZXRwb2xpbmV9CkluZGV4OiBsYW5nL2djYzgtZGV2ZWwvTWFrZWZpbGUK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gbGFuZy9nY2M4LWRldmVsL01ha2VmaWxlCShyZXZpc2lvbiA0ODIxNjUp CisrKyBsYW5nL2djYzgtZGV2ZWwvTWFrZWZpbGUJKHdvcmtpbmcgY29weSkKQEAgLTQwLDYgKzQw LDcgQEAKIFNVRkZJWD0JCSR7UE9SVFZFUlNJT046Qy8oWzAtOV0rKS4qL1wxL30KIFVTRVM9CQlj b21waWxlciBjcGUgZ21ha2UgaWNvbnYgbGlidG9vbCBtYWtlaW5mbyBwZXJsNSB0YXI6eHoKIFVT RV9CSU5VVElMUz0JeWVzCitCSU5BUllfQUxJQVM9CXN0cmlwPSR7TE9DQUxCQVNFfS9iaW4vc3Ry aXAKIFVTRV9QRVJMNT0JYnVpbGQKIFNTUF9VTlNBRkU9CXllcwogCkluZGV4OiBsYW5nL2djYzkt ZGV2ZWwvTWFrZWZpbGUKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gbGFuZy9nY2M5LWRldmVsL01ha2VmaWxlCShy ZXZpc2lvbiA0ODIxNjUpCisrKyBsYW5nL2djYzktZGV2ZWwvTWFrZWZpbGUJKHdvcmtpbmcgY29w eSkKQEAgLTM4LDYgKzM4LDcgQEAKIFNVRkZJWD0JCSR7UE9SVFZFUlNJT046Qy8oWzAtOV0rKS4q L1wxL30KIFVTRVM9CQljb21waWxlciBjcGUgZ21ha2UgaWNvbnYgbGlidG9vbCBtYWtlaW5mbyBw ZXJsNSB0YXI6eHoKIFVTRV9CSU5VVElMUz0JeWVzCitCSU5BUllfQUxJQVM9CXN0cmlwPSR7TE9D QUxCQVNFfS9iaW4vc3RyaXAKIFVTRV9QRVJMNT0JYnVpbGQKIFNTUF9VTlNBRkU9CXllcwogCg== --0000000000001b5a93057851fb83--