From owner-dev-commits-src-main@freebsd.org Sun Jan 17 01:07:40 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id ABD164D2BAA; Sun, 17 Jan 2021 01:07:40 +0000 (UTC) (envelope-from oshogbo.vx@gmail.com) Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DJGx74DXhz3Pjg; Sun, 17 Jan 2021 01:07:39 +0000 (UTC) (envelope-from oshogbo.vx@gmail.com) Received: by mail-lf1-f45.google.com with SMTP id o17so18916676lfg.4; Sat, 16 Jan 2021 17:07:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CKTCMqE66cmRJiK3mMtFVCIe1qVLvnu+0ZfUQDd2vGU=; b=uYrYCRUlVjTpIzscJ3Etam1C1syXgHhEr3dcYF7PJDsgX7g8N8r01XhIq7zF9LKNIW HSGaSbYntYKWs3+LIIYX8Na/Kv53pd+CTdSvixbH81CN7bDa4cF0W9KgRz9qi6REeMFL 9ZjRQVYexsZpH6hPcwNckzb17KMXbTEYHLd+F0EH3iag7amdVRCi0+t9QuomR047YDcU uCccE9wbs4GXjnRJ4FPPWtyxsOMrGrMmDz6FqQotZj5BCC2Xmj05IIZvw00uOii9/TQB qC50VEuz32aTXH8hj30uCKvkVk5qktWJuS6cmSTdkV4AL+nvZEVfoG0r8yOMafisN+5O 0iFQ== X-Gm-Message-State: AOAM533+yUIp60e5+qz7Qg16fz07d649wRxZ/E4AmCNJEN+m/xKTu4mh wMsAtJmHAtJcrczVQSOvRP9UIaSs8a4tBaYa5jnfBR2oaspn1ws3 X-Google-Smtp-Source: ABdhPJxzhYrRd4Lf8RqOs4X2vznub1k7zMrnXLnUx0BHGTzaMjoF5Vg91BLfW4eb1E00RnNzjmHek6CP5ibCdWLatME= X-Received: by 2002:a05:6512:2e9:: with SMTP id m9mr8188219lfq.118.1610845657764; Sat, 16 Jan 2021 17:07:37 -0800 (PST) MIME-Version: 1.0 References: <202101170021.10H0LZEk066670@gitrepo.freebsd.org> <202101170057.10H0vqp6056258@slippy.cwsent.com> In-Reply-To: <202101170057.10H0vqp6056258@slippy.cwsent.com> From: Mariusz Zaborski Date: Sun, 17 Jan 2021 02:07:45 +0100 Message-ID: Subject: Re: git: b7ab6832cd98 - main - cat: disable building it with Casper To: Cy Schubert Cc: src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4DJGx74DXhz3Pjg X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of oshogbovx@gmail.com designates 209.85.167.45 as permitted sender) smtp.mailfrom=oshogbovx@gmail.com X-Spamd-Result: default: False [-1.00 / 15.00]; FROM_NEQ_ENVFROM(0.00)[oshogbo@freebsd.org,oshogbovx@gmail.com]; MAILMAN_DEST(0.00)[dev-commits-src-all,dev-commits-src-main]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; ARC_NA(0.00)[]; NEURAL_SPAM_SHORT(1.00)[1.000]; SPAMHAUS_ZRD(0.00)[209.85.167.45:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[209.85.167.45:from]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCVD_IN_DNSWL_NONE(0.00)[209.85.167.45:from]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FORGED_SENDER(0.30)[oshogbo@freebsd.org,oshogbovx@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.167.45:from]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; RCVD_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Jan 2021 01:07:40 -0000 Hello, Seems like your cat.o wasn't rebuild. Did you use NO_CLEAN flag? It seems to work on: https://github.com/freebsd/freebsd-src/runs/1715237892 and on my machine. Can you try doing: make buildenv cd bin/cat make clean make Thanks, Mariusz On Sun, 17 Jan 2021 at 01:58, Cy Schubert wrote: > > In message <202101170021.10H0LZEk066670@gitrepo.freebsd.org>, Mariusz > Zaborski > writes: > > The branch main has been updated by oshogbo: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=b7ab6832cd988aff7f4e468e507c314d > > d7641638 > > > > commit b7ab6832cd988aff7f4e468e507c314dd7641638 > > Author: Mariusz Zaborski > > AuthorDate: 2021-01-17 00:04:28 +0000 > > Commit: Mariusz Zaborski > > CommitDate: 2021-01-17 00:21:46 +0000 > > > > cat: disable building it with Casper > > > > We want to measure what are the actual cost of sandboxing cat(1). > > > > Requested by: mjg, cy, Mike Karels > > Discussed with: rwatson, markj > > --- > > bin/cat/Makefile | 13 +++++++------ > > 1 file changed, 7 insertions(+), 6 deletions(-) > > > > diff --git a/bin/cat/Makefile b/bin/cat/Makefile > > index abfdcbcfbb2e..cce69d8aad9e 100644 > > --- a/bin/cat/Makefile > > +++ b/bin/cat/Makefile > > @@ -15,11 +15,12 @@ CFLAGS+=-DBOOTSTRAP_CAT > > HAS_TESTS= > > SUBDIR.${MK_TESTS}+= tests > > > > -.if ${MK_CASPER} != "no" && !defined(RESCUE) && !defined(BOOTSTRAPPING) > > -LIBADD+= casper > > -LIBADD+= cap_fileargs > > -LIBADD+= cap_net > > -CFLAGS+=-DWITH_CASPER > > -.endif > > +# Temporary disable building cat with Casper. > > +#.if ${MK_CASPER} != "no" && !defined(RESCUE) && !defined(BOOTSTRAPPING) > > +#LIBADD+= casper > > +#LIBADD+= cap_fileargs > > +#LIBADD+= cap_net > > +#CFLAGS+=-DWITH_CASPER > > +#.endif > > > > .include > > > > Hi, > > Almost there. > > ld: error: undefined symbol: cap_init > >>> referenced by cat.c:154 (/opt/src/git-src/bin/cat/cat.c:154) > >>> cat.o:(main) > > ld: error: undefined symbol: fileargs_cinit > >>> referenced by cat.c:158 (/opt/src/git-src/bin/cat/cat.c:158) > >>> cat.o:(main) > > ld: error: undefined symbol: cap_service_open > >>> referenced by cat.c:131 (/opt/src/git-src/bin/cat/cat.c:131) > >>> cat.o:(main) > > ld: error: undefined symbol: cap_net_limit_init > >>> referenced by cat.c:135 (/opt/src/git-src/bin/cat/cat.c:135) > >>> cat.o:(main) > > ld: error: undefined symbol: cap_net_limit_name2addr_family > >>> referenced by cat.c:141 (/opt/src/git-src/bin/cat/cat.c:141) > >>> cat.o:(main) > --- all_subdir_kerberos5 --- > --- libheimntlm.so.11.debug --- > objcopy --only-keep-debug libheimntlm.so.11.full libheimntlm.so.11.debug > --- libheimntlm.so.11 --- > objcopy --strip-debug --add-gnu-debuglink=libheimntlm.so.11.debug > libheimntlm.so.11.full libheimntlm.so.11 > --- all_subdir_lib --- > --- init_test --- > (cd /opt/src/git-src/lib/csu/tests/dynamic && DEPENDFILE=.depend.init_test > NO_SUBDIR=1 make -f /opt/src/git-src/lib/csu/tests/dynamic/Makefile > _RECURSING_PROGS=t PROG=init_test ) > --- all_subdir_bin --- > ld: error: undefined symbol: cap_net_limit > >>> referenced by cat.c:143 (/opt/src/git-src/bin/cat/cat.c:143) > >>> cat.o:(main) > > ld: error: undefined symbol: cap_close > >>> referenced by cat.c:168 (/opt/src/git-src/bin/cat/cat.c:168) > >>> cat.o:(main) > > ld: error: undefined symbol: fileargs_open > >>> referenced by cat.c:263 (/opt/src/git-src/bin/cat/cat.c:263) > >>> cat.o:(scanfiles) > > ld: error: undefined symbol: fileargs_realpath > >>> referenced by cat.c:441 (/opt/src/git-src/bin/cat/cat.c:441) > >>> cat.o:(scanfiles) > > ld: error: undefined symbol: cap_getaddrinfo > >>> referenced by cat.c:444 (/opt/src/git-src/bin/cat/cat.c:444) > >>> cat.o:(scanfiles) > > ld: error: undefined symbol: cap_connect > >>> referenced by cat.c:468 (/opt/src/git-src/bin/cat/cat.c:468) > >>> cat.o:(scanfiles) > cc: error: linker command failed with exit code 1 (use -v to see invocation) > *** [cat.full] Error code 1 > > make[4]: stopped in /opt/src/git-src/bin/cat > > make[1]: stopped in /opt/src/git-src > > make: stopped in /opt/src/git-src > exiting RC=2: building amd64 > > > -- > Cheers, > Cy Schubert > FreeBSD UNIX: Web: https://FreeBSD.org > NTP: Web: https://nwtime.org > > The need of the many outweighs the greed of the few. > >