From nobody Thu Jul 23 10:01:24 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4h5RTw6GMPz6lWbN for ; Thu, 23 Jul 2026 10:01:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4h5RTw3DmHz3X5y for ; Thu, 23 Jul 2026 10:01:24 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1784800884; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5ppOKrszS03H/RwIk73Rnuh1nA0+b4/nGVX4rkPB0Bc=; b=RHHthCoyAuBWK0ptgeTDCFa+JodgYBLbiyBW7aTn2x61jahE7HXdQlfsp7h77KcO4cemN+ v9jN5X24NSJnLYtKqtdnKkCV2lGqG0y5wqCOSopX/z94/P4TON3F2jRo06njW58qRzn9Vg /dccohRhL/+UghijhzKhQpUcVfJWilDzGu9X4Mq50dqzA5LW+xne9Hv69MR8CcqbaRoaYV rqGJs0EOAMw47dxn8pSVgMY9cRedD/otM4fBGBNvHZMdQS3zKRWOykpFyyui9twsAODMSI NNg6SVaYaAEFv4tz/jHHNOA4+VGXQgruZ0ubzo0b7mlZ2ltAAUXfy+2d5czXdA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1784800884; a=rsa-sha256; cv=none; b=ZqZt+gmHCpDaQFCAjO4MhBLZ+MGtgHT76of0h66c7Y0N7JRMflfw+fJHvf7DlOi9YEJEbL /benMmsCgIxlhP3FyTb7wsAk0CVHu/2xYTQHSSqvaipvzKIMBzFiaS2f0sDNupuGMc+16G PL8eS6Gz5Q8ZigCFSCkeYjX5ubfvvmulIuVWKTjqbREcBc3kLw0uK8fh1ClC3eKV5jxjYd M+FSvb5EGIDQ2WvKe+pMLA74G6GNlH/JnyjpSbIdLwfL7pcspIa1qLI39LH2kYsE+lJB8v m6kK7OLOJogl+kWTbE9tUGGZ8lpgMoLv2mrYAxPUzGfzmvLHZSHS/DsiP6cojQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1784800884; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5ppOKrszS03H/RwIk73Rnuh1nA0+b4/nGVX4rkPB0Bc=; b=exzqDmb65Opa5MKtzRkVUA2vI3LB5+7VpvwmBLMT2xGYevPnqkJXsihJinyv4FTMzkarud EOkcnGxlDLRlqPdEhadUS5fdWTxeZilYqFpwCou8Lxgda0SWrh4wBR2ccJyhqHZxg6xXqo e2O8HUbCiisgWwUjNgfICPxLmORXsj28gFMu/+663SrGTEMjxW+sYay3C/7u8XOkpJmp6c xhn4kHn/X3/2qY53lEURnObAFcsRdxBIzv3Mh3nh3wXIo2SOOqZV6yjpgSF1pHMcvVZ5Mg PYOHx3eR1DvG8GR/Ld/g0CabT7JIBo20MWSjwz94gZGb7eQgg+FACIvvVGi9Yw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4h5RTw2BYMz10tJ for ; Thu, 23 Jul 2026 10:01:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3cf5a by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 23 Jul 2026 10:01:24 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Olivier Certner Subject: git: fc759cca5090 - stable/14 - acpi_cpu(4): Call ACPI_GET_FEATURES() on a reset 'features' variable List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: fc759cca5090840d1fc1fa3825f0dc32f28669ef Auto-Submitted: auto-generated Date: Thu, 23 Jul 2026 10:01:24 +0000 Message-Id: <6a61e674.3cf5a.110b5aed@gitrepo.freebsd.org> The branch stable/14 has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=fc759cca5090840d1fc1fa3825f0dc32f28669ef commit fc759cca5090840d1fc1fa3825f0dc32f28669ef Author: Olivier Certner AuthorDate: 2026-07-07 13:34:21 +0000 Commit: Olivier Certner CommitDate: 2026-07-23 09:59:18 +0000 acpi_cpu(4): Call ACPI_GET_FEATURES() on a reset 'features' variable This is to prevent child drivers from using the features returned by previous drivers (in an arbitrary order). None of the existing ones do that, so this is purely defensive. MFC after: 2 weeks Sponsored by: The FreeBSD Foundation (cherry picked from commit 664ad9ac4c9047d29d5f37d43174e1b469e2ec80) --- sys/dev/acpica/acpi_cpu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/dev/acpica/acpi_cpu.c b/sys/dev/acpica/acpi_cpu.c index 1ea045c4e812..7956ed6f8d43 100644 --- a/sys/dev/acpica/acpi_cpu.c +++ b/sys/dev/acpica/acpi_cpu.c @@ -311,7 +311,6 @@ acpi_cpu_attach(device_t dev) struct acpi_cpu_softc *sc; struct acpi_softc *acpi_sc; ACPI_STATUS status; - u_int features; int cpu_id, drv_count, i; driver_t **drivers; uint32_t cap_set[3]; @@ -415,6 +414,8 @@ acpi_cpu_attach(device_t dev) if (devclass_get_drivers(device_get_devclass(dev), &drivers, &drv_count) == 0) { for (i = 0; i < drv_count; i++) { + u_int features = 0; + if (ACPI_GET_FEATURES(drivers[i], &features) == 0) sc->cpu_features |= features; }