From owner-svn-src-head@freebsd.org  Thu Jun 14 09:10:35 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 242701013D87;
 Thu, 14 Jun 2018 09:10:35 +0000 (UTC)
 (envelope-from tsoome@FreeBSD.org)
Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org
 [IPv6:2610:1c1:1:606c::19:3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "mxrelay.nyi.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id C3EF57F0D2;
 Thu, 14 Jun 2018 09:10:34 +0000 (UTC)
 (envelope-from tsoome@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id A151B2656D;
 Thu, 14 Jun 2018 09:10:34 +0000 (UTC)
 (envelope-from tsoome@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id w5E9AYKL041330;
 Thu, 14 Jun 2018 09:10:34 GMT (envelope-from tsoome@FreeBSD.org)
Received: (from tsoome@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id w5E9AYei041329;
 Thu, 14 Jun 2018 09:10:34 GMT (envelope-from tsoome@FreeBSD.org)
Message-Id: <201806140910.w5E9AYei041329@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: tsoome set sender to
 tsoome@FreeBSD.org using -f
From: Toomas Soome <tsoome@FreeBSD.org>
Date: Thu, 14 Jun 2018 09:10:34 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r335127 - head/stand/libsa
X-SVN-Group: head
X-SVN-Commit-Author: tsoome
X-SVN-Commit-Paths: head/stand/libsa
X-SVN-Commit-Revision: 335127
X-SVN-Commit-Repository: base
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Jun 2018 09:10:35 -0000

Author: tsoome
Date: Thu Jun 14 09:10:34 2018
New Revision: 335127
URL: https://svnweb.freebsd.org/changeset/base/335127

Log:
  libsa: remobe unneeded check before free()
  
  free() is checking for NULL, remove duplicate check.

Modified:
  head/stand/libsa/close.c

Modified: head/stand/libsa/close.c
==============================================================================
--- head/stand/libsa/close.c	Thu Jun 14 09:06:53 2018	(r335126)
+++ head/stand/libsa/close.c	Thu Jun 14 09:10:34 2018	(r335127)
@@ -75,10 +75,9 @@ close(int fd)
 		errno = EBADF;
 		return (-1);
 	}
-	if (f->f_rabuf != NULL) {
-		free(f->f_rabuf);
-		f->f_rabuf = NULL;
-	}
+	free(f->f_rabuf);
+	f->f_rabuf = NULL;
+
 	if (!(f->f_flags & F_RAW) && f->f_ops)
 		err1 = (f->f_ops->fo_close)(f);
 	if (!(f->f_flags & F_NODEV) && f->f_dev)