From owner-freebsd-current@FreeBSD.ORG Tue Jun 18 23:17:53 2013 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 2D998FEB; Tue, 18 Jun 2013 23:17:53 +0000 (UTC) (envelope-from dragonflybsd@marino.st) Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148]) by mx1.freebsd.org (Postfix) with ESMTP id 0B0F91A0B; Tue, 18 Jun 2013 23:17:52 +0000 (UTC) Received: from [192.168.0.11] (d1068.upc-d.chello.nl [213.46.1.68]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id 03666435A3; Tue, 18 Jun 2013 18:17:50 -0500 (CDT) Message-ID: <51C0EA9C.5090502@marino.st> Date: Wed, 19 Jun 2013 01:17:48 +0200 From: John Marino User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Oliver Pinter Subject: Re: gccmakedep fix - 20130619 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Wed, 19 Jun 2013 02:47:16 +0000 Cc: ports@freebsd.org, current@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jun 2013 23:17:53 -0000 On 6/19/2013 01:00, Oliver Pinter wrote: > Hi all! > > Attached a fix to gccmakedep. So.... 1) There's already multiple PRs on this, including one I just submitted: http://www.freebsd.org/cgi/query-pr.cgi?pr=179571 2) Your patch adds an ".endif" which is already there 3) Is not it better to submit via PR (GNATS) rather than a mailing list? That's what PRs are for... John