From owner-freebsd-current@FreeBSD.ORG Sun Sep 19 18:41:30 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DBEEF16A4CE; Sun, 19 Sep 2004 18:41:30 +0000 (GMT) Received: from mp2.macomnet.net (mp2.macomnet.net [195.128.64.6]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3A60343D1F; Sun, 19 Sep 2004 18:41:30 +0000 (GMT) (envelope-from maxim@macomnet.ru) Received-SPF: pass (mp2.macomnet.net: domain of maxim@macomnet.ru designates 127.0.0.1 as permitted sender) receiver=mp2.macomnet.net; client_ip=127.0.0.1; envelope-from=maxim@macomnet.ru; Received: from localhost (localhost [127.0.0.1]) by mp2.macomnet.net (8.12.11/8.12.11) with ESMTP id i8JIfSGG050725; Sun, 19 Sep 2004 22:41:29 +0400 (MSD) (envelope-from maxim@macomnet.ru) Date: Sun, 19 Sep 2004 22:41:28 +0400 (MSD) From: Maxim Konovalov To: current@freebsd.org Message-ID: <20040919222735.N50658@mp2.macomnet.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: truckman@freebsd.org Subject: net.inet.ip.check_interface POLA X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Sep 2004 18:41:31 -0000 Hello, When net.inet.ip.check_interface was MFCed to RELENG_4 3+ years ago in rev. 1.130.2.17 ip_input.c it was 1 by default but shortly changed to 0 (accidently?) in rev. 1.130.2.20 in RELENG_4 only. Among with the fact this knob is not documented it breaks POLA especially in bridge enviroment. I suggest to synchronize HEAD and RELENG_5 with RELENG_4 and make an MFS. I do not like the idea to change net.inet.ip.check_interface to 1 by default in RELENG_4 for the obvious reasons. Any objections? Index: sys/netinet/ip_input.c =================================================================== RCS file: /home/ncvs/src/sys/netinet/ip_input.c,v retrieving revision 1.289 diff -u -r1.289 ip_input.c --- sys/netinet/ip_input.c 16 Sep 2004 18:33:39 -0000 1.289 +++ sys/netinet/ip_input.c 19 Sep 2004 18:35:31 -0000 @@ -148,7 +148,7 @@ * to the loopback interface instead of the interface where the * packets for those addresses are received. */ -static int ip_checkinterface = 1; +static int ip_checkinterface = 0; SYSCTL_INT(_net_inet_ip, OID_AUTO, check_interface, CTLFLAG_RW, &ip_checkinterface, 0, "Verify packet arrives on correct interface"); %%% -- Maxim Konovalov