From owner-freebsd-arm@FreeBSD.ORG Mon Feb 22 00:10:51 2010 Return-Path: Delivered-To: freebsd-arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 63E24106566C; Mon, 22 Feb 2010 00:10:51 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 248CF8FC12; Mon, 22 Feb 2010 00:10:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o1M06H20016655; Sun, 21 Feb 2010 17:06:17 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Sun, 21 Feb 2010 17:06:28 -0700 (MST) Message-Id: <20100221.170628.163350101932654503.imp@bsdimp.com> To: cognet@ci0.org From: "M. Warner Losh" In-Reply-To: <20100221235408.GA65302@ci0.org> References: <4B819F21.70907@FreeBSD.org> <20100221.152518.366306193186912981.imp@bsdimp.com> <20100221235408.GA65302@ci0.org> X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: freebsd-arm@freebsd.org, dougb@freebsd.org Subject: Re: bind on arm X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Feb 2010 00:10:51 -0000 In message: <20100221235408.GA65302@ci0.org> Olivier Houchard writes: : On Sun, Feb 21, 2010 at 03:25:18PM -0700, M. Warner Losh wrote: : > In message: <4B819F21.70907@FreeBSD.org> : > Doug Barton writes: : > : On 02/21/10 07:28, Olivier Houchard wrote: : > : > Hi Doug, : > : > : > : > I'd like to get the attached patch committed. It fixes the bind arm atomic : > : > stuff in -CURRENT and RELENG_8. Some times ago, the RAS address was changed, : > : > but it was hardcoded in the bind code and the change was never reflected. : > : > The patch uses a macro, so that even if it happens again it won't be a problem. : > : : > : First question (and I think the answer is yes, but I need to : > : double-check) is it the consensus of the ARM gurus that this is the : > : right solution? Second question, is this solution something that I can : > : send upstream, both in the sense that I have permission to do so, and : > : that it would be generally applicable to ARM on other OSs? : > : > The fanciest way to cope would be to have a run-time check to see : > which address to use. This likely isn't worth the bother since the : > user base is still relatively small (and none of the other atomics do : > this). The next best approach would be to include : > and use the value defined there for ARM_RAS_START and ARM_RAS_END. : > Again, I've not double checked to make sure they are defined before, : > but I think they are (or at least if they aren't defined, we know to : > use the old value). : > : : Actually, the patch I sent Doug does just that, it uses ARM_RAS_START : (because it includes machine/atomic.h, which includes machine/sysarch.h). : It should work for 7 as well, as ARM_RAS_START was defined too (but in : machine/atomic.h) Hmmm, missed that part of it... Then yes, it is ready to go. Warner