From owner-svn-src-all@FreeBSD.ORG Fri Jan 8 17:08:42 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 258A81065694; Fri, 8 Jan 2010 17:08:42 +0000 (UTC) (envelope-from etnapierala@googlemail.com) Received: from mail-fx0-f227.google.com (mail-fx0-f227.google.com [209.85.220.227]) by mx1.freebsd.org (Postfix) with ESMTP id 32DB08FC12; Fri, 8 Jan 2010 17:08:40 +0000 (UTC) Received: by fxm27 with SMTP id 27so4881596fxm.3 for ; Fri, 08 Jan 2010 09:08:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:sender:subject:mime-version :content-type:from:in-reply-to:date:cc:content-transfer-encoding :message-id:references:to:x-mailer; bh=xc8WOQqwh+N47PPjwZhbLKcqLKaS1t4N2hr92+4yXQ4=; b=xbrRWmrlnUoE8pnJtoYdd4qgm9ksWB9UOpeZCtcDey/TW2dsC6aZ9UmXYA9QY9xvG3 wTl5kxbM7IEFKSZUR7ODsMWShjzVZHkPx7iTtWjzC8ZpaDpG7bs/I/m9PwJKeZG6qLLg sxwXWWYRfi+xTA6LWZvUOAHcaFGCE6SoLYaMI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=sender:subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to:x-mailer; b=nvQ11tnC9NTyXh05BER0zJZQa3ilDWrBa9y6ptJJgMnfs1UES1HGhZWIAOh0VtAXd3 AVbsjw3jDANUrkiBM/NvH/vOcP+Evd0+TP98YCmfXchP2672R8XZAwRSzHzqib8RLlDl YYxQeO4j5nKP3iFYKy9LE6W8qY2ihBFg65OI8= Received: by 10.86.239.21 with SMTP id m21mr9030982fgh.27.1262968906890; Fri, 08 Jan 2010 08:41:46 -0800 (PST) Received: from ?192.168.1.100? (45.81.datacomsa.pl [195.34.81.45]) by mx.google.com with ESMTPS id d4sm49359889fga.21.2010.01.08.08.41.45 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 08 Jan 2010 08:41:46 -0800 (PST) Sender: =?UTF-8?Q?Edward_Napiera=C5=82a?= Mime-Version: 1.0 (Apple Message framework v1077) Content-Type: text/plain; charset=iso-8859-2 From: =?iso-8859-2?Q?Edward_Tomasz_Napiera=B3a?= In-Reply-To: <20100108161210.GC1610@mole.fafoe.narf.at> Date: Fri, 8 Jan 2010 17:41:42 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201001081544.o08FinVh015359@svn.freebsd.org> <20100108161210.GC1610@mole.fafoe.narf.at> To: Stefan Farfeleder X-Mailer: Apple Mail (2.1077) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r201794 - in head/sys: ddb dev/ep dev/ex netinet6 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jan 2010 17:08:42 -0000 Wiadomo=B6=E6 napisana przez Stefan Farfeleder w dniu 2010-01-08, o = godz. 17:12: > On Fri, Jan 08, 2010 at 03:44:49PM +0000, Edward Tomasz Napierala = wrote: >> Author: trasz >> Date: Fri Jan 8 15:44:49 2010 >> New Revision: 201794 >> URL: http://svn.freebsd.org/changeset/base/201794 >>=20 >> Log: >> Replace several instances of 'if (!a & b)' with 'if (!(a &b))' in = order >> to silence newer GCC versions. >=20 > They are not identical, !a & b is parsed as (!a) & b. The code now > seems more correct however. Looks like I've got the operator precedence backwards there - I assumed there was no functional change involved. But yes, the code now looks = more correct - logical 'and' of a constant with the truth value is pointless. -- If you cut off my head, what would I say? Me and my head, or me and my = body?