Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 12 Oct 2009 09:16:42 GMT
From:      Alexander Motin <mav@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 169418 for review
Message-ID:  <200910120916.n9C9GgVX088095@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=169418

Change 169418 by mav@mav_mavtest on 2009/10/12 09:16:05

	Look for bus only when it is needed.

Affected files ...

.. //depot/projects/scottl-camlock/src/sys/cam/cam_xpt.c#105 edit

Differences ...

==== //depot/projects/scottl-camlock/src/sys/cam/cam_xpt.c#105 (text+ko) ====

@@ -4156,8 +4156,6 @@
 
 		sendq->qfrozen_cnt--;
 		if (sendq->qfrozen_cnt == 0) {
-			struct cam_eb *bus;
-
 			/*
 			 * If there is a timeout scheduled to release this
 			 * sim queue, remove it.  The queue frozen count is
@@ -4167,15 +4165,17 @@
 				callout_stop(&sim->callout);
 				sim->flags &= ~CAM_SIM_REL_TIMEOUT_PENDING;
 			}
-			bus = xpt_find_bus(sim->path_id);
 
 			if (run_queue) {
+				struct cam_eb *bus;
+
 				/*
 				 * Now that we are unfrozen run the send queue.
 				 */
+				bus = xpt_find_bus(sim->path_id);
 				xpt_run_dev_sendq(bus);
+				xpt_release_bus(bus);
 			}
-			xpt_release_bus(bus);
 		}
 	}
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200910120916.n9C9GgVX088095>